Code review feedback

spec/features/profiles/user_search_settings_spec.rb

@@ -2,9 +2,7 @@
 
 require 'spec_helper'
 
-RSpec.describe 'User edit profile', :js do
-  include Spec::Support::Helpers::Features::NotesHelpers
-
+RSpec.describe 'User searches their settings', :js do
   let(:user) { create(:user) }
   let(:search_input_placeholder) { 'Search settings' }
 
@@ -12,11 +10,7 @@ RSpec.describe 'User edit profile', :js do
     sign_in(user)
   end
 
-  context 'when seach_settings_in_page feature flag is on' do
-    before do
-      stub_feature_flags(search_settings_in_page: true)
-    end
-
+  context 'when search_settings_in_page feature flag is on' do
     it 'allows searching in the user profile page' do
       search_term = 'Public Avatar'
       hidden_section_name = 'Main settings'
@@ -46,7 +40,7 @@ RSpec.describe 'User edit profile', :js do
     end
   end
 
-  context 'when seach_settings_in_page feature flag is off' do
+  context 'when search_settings_in_page feature flag is off' do
     before do
       stub_feature_flags(search_settings_in_page: false)
       visit(profile_path)

spec/views/layouts/profile.html.haml_spec.rb

@@ -10,22 +10,23 @@ RSpec.describe 'layouts/profile' do
     allow(view).to receive(:current_user).and_return(user)
     allow(view).to receive(:current_user_mode).and_return(Gitlab::Auth::CurrentUserMode.new(user))
     allow(view).to receive(:experiment_enabled?).and_return(false)
+    allow(view).to receive(:enable_search_settings).and_call_original
   end
 
-  context 'when seach_settings_in_page feature flag is on' do
-    before do
-      stub_feature_flags(search_settings_in_page: true)
-    end
+  it 'calls enable_search_settings helper with a custom container class' do
+    render
+    expect(view).to have_received(:enable_search_settings)
+                      .with({ locals: { container_class: 'gl-my-5' } })
+  end
 
+  context 'when search_settings_in_page feature flag is on' do
     it 'displays the search settings entry point' do
       render
       expect(rendered).to include('js-search-settings-app')
-      have_received(:enable_search_settings)
-                            .with({ locals: { container_class: 'gl-my-5' } })
     end
   end
 
-  context 'when seach_settings_in_page feature flag is off' do
+  context 'when search_settings_in_page feature flag is off' do
     before do
       stub_feature_flags(search_settings_in_page: false)
     end
@@ -33,7 +34,6 @@ RSpec.describe 'layouts/profile' do
     it 'does not display the search settings entry point' do
       render
       expect(rendered).not_to include('js-search-settings-app')
-      have_not_received(:enable_search_settings)
     end
   end
 end