Commit 8aadc080 authored by Maxime Orefice's avatar Maxime Orefice Committed by Dylan Griffith

Fix codequality empty base report

parent e876311b
...@@ -8,6 +8,7 @@ module Gitlab ...@@ -8,6 +8,7 @@ module Gitlab
STATUS_SUCCESS = 'success' STATUS_SUCCESS = 'success'
STATUS_FAILED = 'failed' STATUS_FAILED = 'failed'
STATUS_NOT_FOUND = 'not_found'
attr_reader :base_report, :head_report attr_reader :base_report, :head_report
...@@ -17,7 +18,13 @@ module Gitlab ...@@ -17,7 +18,13 @@ module Gitlab
end end
def status def status
success? ? STATUS_SUCCESS : STATUS_FAILED if success?
STATUS_SUCCESS
elsif base_report.nil? || head_report.nil?
STATUS_NOT_FOUND
else
STATUS_FAILED
end
end end
def success? def success?
......
...@@ -45,6 +45,30 @@ RSpec.describe Gitlab::Ci::Reports::ReportsComparer do ...@@ -45,6 +45,30 @@ RSpec.describe Gitlab::Ci::Reports::ReportsComparer do
expect(status).to eq('failed') expect(status).to eq('failed')
end end
end end
context 'when base_report is nil' do
let(:base_report) { nil }
before do
allow(comparer).to receive(:success?).and_return(false)
end
it 'returns status not_found' do
expect(status).to eq('not_found')
end
end
context 'when head_report is nil' do
let(:head_report) { nil }
before do
allow(comparer).to receive(:success?).and_return(false)
end
it 'returns status not_found' do
expect(status).to eq('not_found')
end
end
end end
describe '#success?' do describe '#success?' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment