Commit 8b91a695 authored by Bryce Johnson's avatar Bryce Johnson

Write unapproval integration test.

parent 977d1ca7
...@@ -162,8 +162,6 @@ feature 'Merge request approvals', js: true, feature: true do ...@@ -162,8 +162,6 @@ feature 'Merge request approvals', js: true, feature: true do
end end
context 'when group is assigned to a project' do context 'when group is assigned to a project' do
it 'I am able to unapprove' do
end
it 'I am able to approve' do it 'I am able to approve' do
create :approver_group, group: group, target: project create :approver_group, group: group, target: project
...@@ -175,12 +173,10 @@ feature 'Merge request approvals', js: true, feature: true do ...@@ -175,12 +173,10 @@ feature 'Merge request approvals', js: true, feature: true do
expect(page).to have_content("Approved by") expect(page).to have_content("Approved by")
end end
end end
context 'when group is assigned to a merge request' do context 'when group is assigned to a merge request' do
it 'I am able to unapprove' do
end
it 'I am able to approve' do it 'I am able to approve' do
create :approver_group, group: group, target: merge_request create :approver_group, group: group, target: merge_request
...@@ -194,4 +190,39 @@ feature 'Merge request approvals', js: true, feature: true do ...@@ -194,4 +190,39 @@ feature 'Merge request approvals', js: true, feature: true do
end end
end end
end end
context 'Unapproving by approvers from groups' do
let(:other_user) { create(:user) }
let(:merge_request) { create(:merge_request, source_project: project) }
let(:group) { create :group }
before do
project.team << [user, :developer]
group.add_developer(other_user)
group.add_developer(user)
login_as(user)
create :approver_group, group: group, target: project
visit namespace_project_merge_request_path(project.namespace, project, merge_request)
page.within '.mr-state-widget' do
click_button 'Approve Merge Request'
end
wait_for_ajax
end
it 'I am able to unapprove' do
page.within '.mr-state-widget' do
click_button 'Remove your approval'
end
expect(page).not_to have_content("Approved by")
end
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment