Merge branch '6228-bs-modal' into 'master'

Resolve "Merge Request > Security Reports > Vulnerability Modal broken with Bootstrap 4 update"

Closes #6228

See merge request gitlab-org/gitlab-ee!5972

ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue

@@ -66,13 +66,13 @@ export default {
         class="row prepend-top-10 append-bottom-10"
         :key="index"
       >
-        <label class="col-sm-2 text-right">
+        <label class="col-sm-2 text-right font-weight-bold">
           {{ field.text }}:
         </label>
         <div class="col-sm-10 text-secondary">
           <div
             v-if="hasInstances(field, key)"
-            class="well"
+            class="info-well"
           >
             <ul class="report-block-list">
               <li
@@ -163,7 +163,7 @@ export default {
       </div>
 
       <div class="row prepend-top-20 append-bottom-10">
-        <div class="col-sm-10 col-sm-offset-2 text-secondary">
+        <div class="col-sm-10 offset-sm-2 text-secondary">
           <template v-if="hasDismissedBy">
             {{ s__('ciReport|Dismissed by') }}
             <a

ee/app/assets/stylesheets/pages/security_reports.scss

@@ -125,9 +125,6 @@
 .modal-security-report-dast {
   .modal-dialog {
     width: $modal-lg;
-  }
-  // TODO remove this when gl_modal support not rendering the footer
-  .modal-footer {
-    display: block;
+    max-width: $modal-lg;
   }
 }