Merge branch...

Merge branch '202600-migrate-fa-spinner-to-spinner-for-app-views-shared-_new_project_item_select-html-haml' into 'master'

Migrate app/views/shared/_new_project_item_select.html.haml FA icons

See merge request gitlab-org/gitlab!38177

app/assets/stylesheets/framework/secondary_navigation_elements.scss

@@ -415,7 +415,3 @@
     }
   }
 }
-
-.new-project-item-select-button .fa-caret-down {
-  margin-left: 2px;
-}

app/views/shared/_new_project_item_select.html.haml

 - if any_projects?(@projects)
   .project-item-select-holder.btn-group
     %a.btn.btn-success.new-project-item-link.qa-new-project-item-link{ href: '', data: { label: local_assigns[:label], type: local_assigns[:type] } }
-      = icon('spinner spin')
+      = loading_icon(color: 'light')
     = project_select_tag :project_path, class: "project-item-select", data: { include_groups: local_assigns[:include_groups], order_by: 'last_activity_at', relative_path: local_assigns[:path], with_shared: local_assigns[:with_shared], include_projects_in_subgroups: local_assigns[:include_projects_in_subgroups] }, with_feature_enabled: local_assigns[:with_feature_enabled]
-    %button.btn.btn-success.new-project-item-select-button.qa-new-project-item-select-button
-      = icon('caret-down')
+    %button.btn.btn-success.new-project-item-select-button.qa-new-project-item-select-button.gl-p-0
+      = sprite_icon('chevron-down', size: 16)

changelogs/unreleased/202600-migrate-fa-spinner-to-spinner-for-app-views-shared-_new_project_it.yml

+---
+title: Migrate new project item select FA icons
+merge_request: 38177
+author:
+type: changed