Commit 8d22ff8c authored by Stan Hu's avatar Stan Hu

Fix failing spec in ./spec/features/projects/new_project_spec.rb

parent d2fd6d23
...@@ -9,20 +9,22 @@ module NamespacesHelper ...@@ -9,20 +9,22 @@ module NamespacesHelper
.includes(:route) .includes(:route)
.order('routes.path') .order('routes.path')
users = [current_user.namespace] users = [current_user.namespace]
selected_option = nil
unless extra_group.nil? || extra_group.is_a?(Group) unless extra_group.nil? || extra_group.is_a?(Group)
extra_group = Group.find(extra_group) if Namespace.find(extra_group).kind == 'group' extra_group = Group.find(extra_group) if Namespace.find(extra_group).kind == 'group'
end end
if extra_group && extra_group.is_a?(Group) if extra_group && extra_group.is_a?(Group)
# Avoid duplicate groups if one already exists by that name # Many importers create a temporary Group, so use the real
existing_group = Group.find_by(name: extra_group.name) # group if one exists by that name to prevent duplicates.
extra_group = existing_group if existing_group unless extra_group.persisted?
existing_group = Group.find_by(name: extra_group.name)
extra_group = existing_group if existing_group
end
if Ability.allowed?(current_user, :read_group, extra_group) if Ability.allowed?(current_user, :read_group, extra_group)
selected = extra_group.id if selected == :extra_group
groups |= [extra_group] groups |= [extra_group]
selected_option = extra_group.id if selected == :extra_group
end end
end end
...@@ -32,12 +34,12 @@ module NamespacesHelper ...@@ -32,12 +34,12 @@ module NamespacesHelper
unless groups_only unless groups_only
options << options_for_group(users, display_path: display_path, type: 'user') options << options_for_group(users, display_path: display_path, type: 'user')
if (selected == :current_user || selected_option.nil?) && current_user.namespace if selected == :current_user && current_user.namespace
selected_option = current_user.namespace.id selected = current_user.namespace.id
end end
end end
grouped_options_for_select(options, selected_option) grouped_options_for_select(options, selected)
end end
def namespace_icon(namespace, size = 40) def namespace_icon(namespace, size = 40)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment