Merge branch 'al-enable-admin-new-user-signups-cap-flag-by-default' into 'master'

Enable admin_new_user_signups_cap flag by default

See merge request gitlab-org/gitlab!49761

ee/app/controllers/ee/admin/application_settings_controller.rb

@@ -57,7 +57,7 @@ module EE
           attrs << :maintenance_mode_message
         end
 
-        attrs << :new_user_signups_cap if ::Feature.enabled?(:admin_new_user_signups_cap)
+        attrs << :new_user_signups_cap if ::Feature.enabled?(:admin_new_user_signups_cap, default_enabled: true )
 
         attrs
       end

ee/app/helpers/ee/user_callouts_helper.rb

@@ -91,7 +91,7 @@ module EE
     end
 
     def show_new_user_signups_cap_reached?
-      return false unless ::Feature.enabled?(:admin_new_user_signups_cap)
+      return false unless ::Feature.enabled?(:admin_new_user_signups_cap, default_enabled: true )
       return false unless current_user&.admin?
       return false if user_dismissed?(NEW_USER_SIGNUPS_CAP_REACHED)
 

ee/app/models/ee/application_setting.rb

@@ -349,7 +349,7 @@ module EE
     end
 
     def should_apply_user_signup_cap?
-      ::Feature.enabled?(:admin_new_user_signups_cap) &&
+      ::Feature.enabled?(:admin_new_user_signups_cap, default_enabled: true ) &&
         ::Gitlab::CurrentSettings.new_user_signups_cap.present?
     end
 

ee/app/services/ee/application_settings/update_service.rb

@@ -48,7 +48,7 @@ module EE
 
       def user_cap_increased?
         return false unless application_setting.previous_changes.key?(:new_user_signups_cap)
-        return false unless ::Feature.enabled?(:admin_new_user_signups_cap)
+        return false unless ::Feature.enabled?(:admin_new_user_signups_cap, default_enabled: true )
 
         previous_user_cap, current_user_cap = application_setting.previous_changes[:new_user_signups_cap]
 

ee/app/views/admin/application_settings/_new_user_signups_cap.html.haml

-- return unless ::Feature.enabled?(:admin_new_user_signups_cap)
+- return unless ::Feature.enabled?(:admin_new_user_signups_cap, default_enabled: true )
 
 .form-group
   = form.label :new_user_signups_cap, s_('AdminArea|User cap'), class: 'label-bold'

ee/changelogs/unreleased/al-enable-admin-new-user-signups-cap-flag-by-default.yml

+---
+title: Introduce User Cap admin setting
+merge_request: 49761
+author:
+type: added

ee/config/feature_flags/development/admin_new_user_signups_cap.yml

 ---
 name: admin_new_user_signups_cap
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/45643
-rollout_issue_url: 
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/292600
 milestone: '13.6'
 type: development
 group: group::purchase
-default_enabled: false
+default_enabled: true