Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8eaed8ff
Commit
8eaed8ff
authored
Jul 20, 2020
by
Alexander Turinske
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update translation to include + sign
- update tests to be stronger
parent
41b2240a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
4 deletions
+6
-4
ee/app/assets/javascripts/security_dashboard/components/vulnerability_list.vue
...ipts/security_dashboard/components/vulnerability_list.vue
+1
-2
ee/spec/frontend/security_dashboard/components/vulnerability_list_spec.js
.../security_dashboard/components/vulnerability_list_spec.js
+5
-2
No files found.
ee/app/assets/javascripts/security_dashboard/components/vulnerability_list.vue
View file @
8eaed8ff
...
@@ -342,8 +342,7 @@ export default {
...
@@ -342,8 +342,7 @@ export default {
data-testid=
"vulnerability-more-identifiers"
data-testid=
"vulnerability-more-identifiers"
class=
"gl-text-gray-500"
class=
"gl-text-gray-500"
>
>
<span>
+
</span>
<gl-sprintf
:message=
"__('+ %
{count} more')">
<gl-sprintf
:message=
"__('%
{count} more')">
<template
#count
>
<template
#count
>
{{
extraIdentifierCount
(
item
.
identifiers
)
}}
{{
extraIdentifierCount
(
item
.
identifiers
)
}}
</
template
>
</
template
>
...
...
ee/spec/frontend/security_dashboard/components/vulnerability_list_spec.js
View file @
8eaed8ff
...
@@ -11,6 +11,7 @@ import VulnerabilityList, {
...
@@ -11,6 +11,7 @@ import VulnerabilityList, {
import
FiltersProducedNoResults
from
'
ee/security_dashboard/components/empty_states/filters_produced_no_results.vue
'
;
import
FiltersProducedNoResults
from
'
ee/security_dashboard/components/empty_states/filters_produced_no_results.vue
'
;
import
DashboardHasNoVulnerabilities
from
'
ee/security_dashboard/components/empty_states/dashboard_has_no_vulnerabilities.vue
'
;
import
DashboardHasNoVulnerabilities
from
'
ee/security_dashboard/components/empty_states/dashboard_has_no_vulnerabilities.vue
'
;
import
{
generateVulnerabilities
,
vulnerabilities
}
from
'
./mock_data
'
;
import
{
generateVulnerabilities
,
vulnerabilities
}
from
'
./mock_data
'
;
import
{
trimText
}
from
'
helpers/text_helper
'
;
describe
(
'
Vulnerability list component
'
,
()
=>
{
describe
(
'
Vulnerability list component
'
,
()
=>
{
useLocalStorageSpy
();
useLocalStorageSpy
();
...
@@ -217,10 +218,12 @@ describe('Vulnerability list component', () => {
...
@@ -217,10 +218,12 @@ describe('Vulnerability list component', () => {
const
firstIdentifiers
=
newVulnerabilities
[
0
].
identifiers
;
const
firstIdentifiers
=
newVulnerabilities
[
0
].
identifiers
;
expect
(
identifiers
.
at
(
0
).
text
()).
toBe
(
firstIdentifiers
[
0
].
name
);
expect
(
identifiers
.
at
(
0
).
text
()).
toBe
(
firstIdentifiers
[
0
].
name
);
expect
(
extraIdentifierCounts
.
at
(
0
).
text
()).
toContain
(
firstIdentifiers
.
length
-
1
);
expect
(
trimText
(
extraIdentifierCounts
.
at
(
0
).
text
())).
toContain
(
`
${
firstIdentifiers
.
length
-
1
}
more`
,
);
expect
(
identifiers
.
at
(
1
).
text
()).
toBe
(
newVulnerabilities
[
1
].
identifiers
[
0
].
name
);
expect
(
identifiers
.
at
(
1
).
text
()).
toBe
(
newVulnerabilities
[
1
].
identifiers
[
0
].
name
);
expect
(
extraIdentifierCounts
.
length
).
toBe
(
1
);
expect
(
extraIdentifierCounts
).
toHaveLength
(
1
);
});
});
it
(
'
should display the vulnerability report type
'
,
()
=>
{
it
(
'
should display the vulnerability report type
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment