Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8eec7879
Commit
8eec7879
authored
Aug 23, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
bdac9dc6
a93612aa
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
3 deletions
+10
-3
app/helpers/notifications_helper.rb
app/helpers/notifications_helper.rb
+2
-2
app/views/shared/issuable/_sidebar.html.haml
app/views/shared/issuable/_sidebar.html.haml
+3
-1
changelogs/unreleased/fe-fix-issuable-sidebar-icon-of-notification-disabled.yml
...fe-fix-issuable-sidebar-icon-of-notification-disabled.yml
+5
-0
No files found.
app/helpers/notifications_helper.rb
View file @
8eec7879
...
...
@@ -106,9 +106,9 @@ module NotificationsHelper
end
end
def
notification_setting_icon
(
notification_setting
)
def
notification_setting_icon
(
notification_setting
=
nil
)
sprite_icon
(
notification_setting
.
disabled?
?
"notifications-off"
:
"notifications"
,
!
notification_setting
.
present?
||
notification_setting
.
disabled?
?
"notifications-off"
:
"notifications"
,
css_class:
"icon notifications-icon js-notifications-icon"
)
end
...
...
app/views/shared/issuable/_sidebar.html.haml
View file @
8eec7879
...
...
@@ -139,7 +139,9 @@
-
if
signed_in
-
if
issuable_sidebar
[
:project_emails_disabled
]
.block.js-emails-disabled
=
notification_description
(
:owner_disabled
)
.sidebar-collapsed-icon.has-tooltip
{
title:
notification_description
(
:owner_disabled
),
data:
{
placement:
"left"
,
container:
"body"
,
boundary:
'viewport'
}
}
=
notification_setting_icon
.hide-collapsed
=
notification_description
(
:owner_disabled
)
-
else
.js-sidebar-subscriptions-entry-point
...
...
changelogs/unreleased/fe-fix-issuable-sidebar-icon-of-notification-disabled.yml
0 → 100644
View file @
8eec7879
---
title
:
Fix issuable sidebar icon on notification disabled
merge_request
:
32134
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment