Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-database' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/database

See merge request gitlab-org/gitlab!58251

.rubocop_manual_todo.yml

@@ -697,8 +697,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/closing_issue_extractor_spec.rb
     - spec/lib/gitlab/composer/cache_spec.rb
     - spec/lib/gitlab/data_builder/wiki_page_spec.rb
-    - spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb
-    - spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb
     - spec/lib/gitlab/deploy_key_access_spec.rb
     - spec/lib/gitlab/email/handler/service_desk_handler_spec.rb
     - spec/lib/gitlab/git/lfs_changes_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-database.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/database
+merge_request: 58251
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb

@@ -10,6 +10,7 @@ RSpec.describe Gitlab::Database::PartitioningMigrationHelpers::ForeignKeyHelpers
   end
 
   let_it_be(:connection) { ActiveRecord::Base.connection }
+
   let(:referenced_table) { :issues }
   let(:function_name) { '_test_partitioned_foreign_keys_function' }
   let(:trigger_name) { '_test_partitioned_foreign_keys_trigger' }

spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb

@@ -12,6 +12,7 @@ RSpec.describe Gitlab::Database::PartitioningMigrationHelpers::TableManagementHe
   end
 
   let_it_be(:connection) { ActiveRecord::Base.connection }
+
   let(:source_table) { :_test_original_table }
   let(:partitioned_table) { '_test_migration_partitioned_table' }
   let(:function_name) { '_test_migration_function_name' }