Merge branch '339476-add-notice-when-assigning-projects' into 'master'

Add notice when runner projects are updated

See merge request gitlab-org/gitlab!70151

app/controllers/admin/runner_projects_controller.rb

@@ -9,7 +9,7 @@ class Admin::RunnerProjectsController < Admin::ApplicationController
     @runner = Ci::Runner.find(params[:runner_project][:runner_id])
 
     if @runner.assign_to(@project, current_user)
-      redirect_to admin_runner_path(@runner)
+      redirect_to admin_runner_path(@runner), notice: s_('Runners|Runner assigned to project.')
     else
       redirect_to admin_runner_path(@runner), alert: 'Failed adding runner to project'
     end
@@ -20,7 +20,7 @@ class Admin::RunnerProjectsController < Admin::ApplicationController
     runner = rp.runner
     rp.destroy
 
-    redirect_to admin_runner_path(runner), status: :found
+    redirect_to admin_runner_path(runner), status: :found, notice: s_('Runners|Runner unassigned from project.')
   end
 
   private

app/controllers/projects/runner_projects_controller.rb

@@ -15,7 +15,7 @@ class Projects::RunnerProjectsController < Projects::ApplicationController
     path = project_runners_path(project)
 
     if @runner.assign_to(project, current_user)
-      redirect_to path
+      redirect_to path, notice: s_('Runners|Runner assigned to project.')
     else
       assign_to_messages = @runner.errors.messages[:assign_to]
       alert = assign_to_messages&.join(',') || 'Failed adding runner to project'
@@ -28,6 +28,6 @@ class Projects::RunnerProjectsController < Projects::ApplicationController
     runner_project = project.runner_projects.find(params[:id])
     runner_project.destroy
 
-    redirect_to project_runners_path(project), status: :found
+    redirect_to project_runners_path(project), status: :found, notice: s_('Runners|Runner unassigned from project.')
   end
 end

locale/gitlab.pot

@@ -29142,6 +29142,9 @@ msgstr ""
 msgid "Runners|Runner #%{runner_id}"
 msgstr ""
 
+msgid "Runners|Runner assigned to project."
+msgstr ""
+
 msgid "Runners|Runner is offline, last contact was %{runner_contact} ago"
 msgstr ""
 
@@ -29154,6 +29157,9 @@ msgstr ""
 msgid "Runners|Runner registration"
 msgstr ""
 
+msgid "Runners|Runner unassigned from project."
+msgstr ""
+
 msgid "Runners|Runners"
 msgstr ""
 

spec/features/admin/admin_runners_spec.rb

@@ -356,6 +356,7 @@ RSpec.describe "Admin Runners" do
 
           assigned_project = page.find('[data-testid="assigned-projects"]')
 
+          expect(page).to have_content('Runner assigned to project.')
           expect(assigned_project).to have_content(@project2.path)
         end
       end
@@ -399,13 +400,14 @@ RSpec.describe "Admin Runners" do
         visit admin_runner_path(runner)
       end
 
-      it 'enables specific runner for project' do
+      it 'removed specific runner from project' do
         within '[data-testid="assigned-projects"]' do
           click_on 'Disable'
         end
 
         new_runner_project = page.find('[data-testid="unassigned-projects"]')
 
+        expect(page).to have_content('Runner unassigned from project.')
         expect(new_runner_project).to have_content(@project1.path)
       end
     end