Default FDW to false on Geo::AttachmentRegistryFinder

The feature flag have that disable the FDW queries
has been enabled by default and will be removed.

ee/app/finders/geo/attachment_registry_finder.rb

@@ -2,10 +2,8 @@
 
 module Geo
   class AttachmentRegistryFinder < FileRegistryFinder
-    # Counts all existing registries independent
-    # of any change on filters / selective sync
     def count_registry
-      Geo::UploadRegistry.count
+      syncable.count
     end
 
     def count_syncable
@@ -13,25 +11,19 @@ module Geo
     end
 
     def count_synced
-      registries_for_attachments.merge(Geo::UploadRegistry.synced).count
+      syncable.synced.count
     end
 
     def count_failed
-      registries_for_attachments.merge(Geo::UploadRegistry.failed).count
+      syncable.failed.count
     end
 
     def count_synced_missing_on_primary
-      registries_for_attachments
-        .merge(Geo::UploadRegistry.synced)
-        .merge(Geo::UploadRegistry.missing_on_primary)
-        .count
+      syncable.synced.missing_on_primary.count
     end
 
     def syncable
-      return attachments if selective_sync?
-      return Upload.with_files_stored_locally if local_storage_only?
-
-      Upload
+      Geo::UploadRegistry
     end
 
     # Returns untracked uploads as well as tracked uploads that are unused.
@@ -57,13 +49,13 @@ module Geo
     def find_registry_differences(range)
       # rubocop:disable CodeReuse/ActiveRecord
       source =
-        attachments(fdw: false)
+        attachments
             .id_in(range)
             .pluck(::Upload.arel_table[:id], ::Upload.arel_table[:uploader])
             .map! { |id, uploader| [id, uploader.sub(/Uploader\z/, '').underscore] }
 
       tracked =
-        Geo::UploadRegistry
+        syncable
             .model_id_in(range)
             .pluck(:file_id, :file_type)
       # rubocop:enable CodeReuse/ActiveRecord
@@ -92,48 +84,21 @@ module Geo
     # @param [Array<Integer>] except_ids ids that will be ignored from the query
     # rubocop:disable CodeReuse/ActiveRecord
     def find_never_synced_registries(batch_size:, except_ids: [])
-      Geo::UploadRegistry
+      syncable
         .never
         .model_id_not_in(except_ids)
         .limit(batch_size)
     end
+    alias_method :find_unsynced, :find_never_synced_registries
     # rubocop:enable CodeReuse/ActiveRecord
 
-    # Deprecated in favor of the process using
-    # #find_registry_differences and #find_never_synced_registries
-    #
-    # Find limited amount of non replicated attachments.
-    #
-    # You can pass a list with `except_ids:` so you can exclude items you
-    # already scheduled but haven't finished and aren't persisted to the database yet
-    #
-    # TODO: Alternative here is to use some sort of window function with a cursor instead
-    #       of simply limiting the query and passing a list of items we don't want
-    #
-    # @param [Integer] batch_size used to limit the results returned
-    # @param [Array<Integer>] except_ids ids that will be ignored from the query
-    # rubocop: disable CodeReuse/ActiveRecord
-    def find_unsynced(batch_size:, except_ids: [])
-      attachments
-        .missing_registry
-        .id_not_in(except_ids)
-        .limit(batch_size)
-    end
-    # rubocop: enable CodeReuse/ActiveRecord
-
-    # rubocop: disable CodeReuse/ActiveRecord
     def find_migrated_local(batch_size:, except_ids: [])
-      all_attachments
-        .inner_join_registry
-        .with_files_stored_remotely
-        .id_not_in(except_ids)
-        .limit(batch_size)
+      Geo::UploadRegistry.none
     end
-    # rubocop: enable CodeReuse/ActiveRecord
 
     # rubocop: disable CodeReuse/ActiveRecord
     def find_retryable_failed_registries(batch_size:, except_ids: [])
-      Geo::UploadRegistry
+      syncable
         .failed
         .retry_due
         .model_id_not_in(except_ids)
@@ -143,7 +108,7 @@ module Geo
 
     # rubocop: disable CodeReuse/ActiveRecord
     def find_retryable_synced_missing_on_primary_registries(batch_size:, except_ids: [])
-      Geo::UploadRegistry
+      syncable
         .synced
         .missing_on_primary
         .retry_due
@@ -154,16 +119,12 @@ module Geo
 
     private
 
-    def attachments(fdw: true)
-      local_storage_only?(fdw: fdw) ? all_attachments(fdw: fdw).with_files_stored_locally : all_attachments(fdw: fdw)
-    end
-
-    def all_attachments(fdw: true)
-      current_node(fdw: fdw).attachments
+    def attachments
+      local_storage_only?(fdw: false) ? all_attachments.with_files_stored_locally : all_attachments
     end
 
-    def registries_for_attachments
-      attachments.inner_join_registry
+    def all_attachments
+      current_node(fdw: false).attachments
     end
   end
 end