check for `read_only?` first before seeing if request is disallowed

91075c82 · digitalMoksha · cba68d33 · 91075c82
Commit 91075c82 authored Nov 21, 2017 by digitalMoksha
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

lib/gitlab/middleware/read_only.rb lib/gitlab/middleware/read_only.rb +1 -1

No files found.
--- a/lib/gitlab/middleware/read_only.rb
+++ b/lib/gitlab/middleware/read_only.rb
@@ -14,7 +14,7 @@ module Gitlab
        @env = env
        @route_hash = nil
-        if disallowed_request? && Gitlab::Database.read_only?
+        if Gitlab::Database.read_only? && disallowed_request?
          Rails.logger.debug('GitLab ReadOnly: preventing possible non read-only operation')
          error_message = 'You cannot do writing operations on a read-only GitLab instance'