Commit 91ddcecb authored by Jose Ivan Vargas's avatar Jose Ivan Vargas

Merge branch '352128-add-autocomplete-off' into 'master'

Add autocomplete off to text inputs

See merge request gitlab-org/gitlab!81381
parents 872a0e51 f4188054
...@@ -207,7 +207,7 @@ export default { ...@@ -207,7 +207,7 @@ export default {
{{ $options.i18n.description }} {{ $options.i18n.description }}
</p> </p>
</header> </header>
<gl-form @submit.prevent="submitForm"> <gl-form autocomplete="off" @submit.prevent="submitForm">
<gl-alert v-if="shouldShowAlert" variant="danger" dismissible @dismiss="dismissAlert"> <gl-alert v-if="shouldShowAlert" variant="danger" dismissible @dismiss="dismissAlert">
<ul v-if="errors.length > 1" class="gl-mb-0 gl-pl-5"> <ul v-if="errors.length > 1" class="gl-mb-0 gl-pl-5">
<li v-for="error in errors" :key="error">{{ error }}</li> <li v-for="error in errors" :key="error">{{ error }}</li>
......
...@@ -122,10 +122,10 @@ export default { ...@@ -122,10 +122,10 @@ export default {
:aria-label="$options.i18n.removeIdentifierRow" :aria-label="$options.i18n.removeIdentifierRow"
@click="removeIdentifier(index)" @click="removeIdentifier(index)"
/> />
<!-- <!--
The first row does not contain a remove button and this creates The first row does not contain a remove button and this creates
a misalignment. This button is here as a placeholder to align the rows, a misalignment. This button is here as a placeholder to align the rows,
it's not visible to the user but it occupies the space hence aligns the it's not visible to the user but it occupies the space hence aligns the
rows properly. rows properly.
--> -->
<gl-button <gl-button
......
...@@ -91,6 +91,10 @@ describe('New vulnerability component', () => { ...@@ -91,6 +91,10 @@ describe('New vulnerability component', () => {
expect(wrapper.findComponent(GlForm).exists()).toBe(true); expect(wrapper.findComponent(GlForm).exists()).toBe(true);
}); });
it('has autocomplete turned off', () => {
expect(wrapper.findComponent(GlForm).attributes('autocomplete')).toBe('off');
});
it.each` it.each`
section | selector | fields section | selector | fields
${'Name and Description'} | ${findSectionName} | ${inputs.sectionName} ${'Name and Description'} | ${findSectionName} | ${inputs.sectionName}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment