Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
91f7e4d4
Commit
91f7e4d4
authored
Apr 13, 2021
by
Jackie Fraser
Committed by
Etienne Baqué
Apr 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Convert upgrade link experiment to feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
parent
ca02d83c
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
14 additions
and
6 deletions
+14
-6
config/feature_flags/development/upgrade_link_in_user_menu_a.yml
...feature_flags/development/upgrade_link_in_user_menu_a.yml
+8
-0
ee/app/helpers/ee/users_helper.rb
ee/app/helpers/ee/users_helper.rb
+1
-1
ee/changelogs/unreleased/300824-experiment-cleanup-upgrade_link_in_user_menu_a.yml
...300824-experiment-cleanup-upgrade_link_in_user_menu_a.yml
+5
-0
lib/gitlab/experimentation.rb
lib/gitlab/experimentation.rb
+0
-4
spec/lib/gitlab/experimentation_spec.rb
spec/lib/gitlab/experimentation_spec.rb
+0
-1
No files found.
ee/config/feature_flags/experiment/upgrade_link_in_user_menu_a_experiment_percentage
.yml
→
config/feature_flags/development/upgrade_link_in_user_menu_a
.yml
View file @
91f7e4d4
---
name
:
upgrade_link_in_user_menu_a
_experiment_percentage
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/
29428
rollout_issue_url
:
https://gitlab.com/gitlab-org/g
rowth/team-tasks/-/issues/126
milestone
:
'
13.
0
'
type
:
experi
ment
name
:
upgrade_link_in_user_menu_a
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/
56591
rollout_issue_url
:
https://gitlab.com/gitlab-org/g
itlab/-/issues/300824
milestone
:
'
13.
11
'
type
:
develop
ment
group
:
group::expansion
default_enabled
:
fals
e
default_enabled
:
tru
e
ee/app/helpers/ee/users_helper.rb
View file @
91f7e4d4
...
...
@@ -23,7 +23,7 @@ module EE
def
show_upgrade_link?
(
user
)
return
unless
user
return
unless
::
Gitlab
.
com?
return
unless
experiment_enabled?
(
:upgrade_link_in_user_menu_a
)
return
unless
::
Feature
.
enabled?
(
:upgrade_link_in_user_menu_a
,
default_enabled: :yaml
)
Rails
.
cache
.
fetch
([
'users'
,
user
.
id
,
'show_upgrade_link?'
],
expires_in:
10
.
minutes
)
do
user
.
owns_upgradeable_namespace?
...
...
ee/changelogs/unreleased/300824-experiment-cleanup-upgrade_link_in_user_menu_a.yml
0 → 100644
View file @
91f7e4d4
---
title
:
Add upgrade link in user menu
merge_request
:
56591
author
:
type
:
added
lib/gitlab/experimentation.rb
View file @
91f7e4d4
...
...
@@ -34,10 +34,6 @@
module
Gitlab
module
Experimentation
EXPERIMENTS
=
{
upgrade_link_in_user_menu_a:
{
tracking_category:
'Growth::Expansion::Experiment::UpgradeLinkInUserMenuA'
,
use_backwards_compatible_subject_index:
true
},
invite_members_version_b:
{
tracking_category:
'Growth::Expansion::Experiment::InviteMembersVersionB'
,
use_backwards_compatible_subject_index:
true
...
...
spec/lib/gitlab/experimentation_spec.rb
View file @
91f7e4d4
...
...
@@ -7,7 +7,6 @@ require 'spec_helper'
RSpec
.
describe
Gitlab
::
Experimentation
::
EXPERIMENTS
do
it
'temporarily ensures we know what experiments exist for backwards compatibility'
do
expected_experiment_keys
=
[
:upgrade_link_in_user_menu_a
,
:invite_members_version_b
,
:invite_members_empty_group_version_a
,
:contact_sales_btn_in_app
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment