Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9214463a
Commit
9214463a
authored
Aug 12, 2020
by
Jay Swain
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Feedback: GlLink => GlButton
parent
a8d33267
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
5 deletions
+6
-5
app/assets/javascripts/whats_new/components/trigger.vue
app/assets/javascripts/whats_new/components/trigger.vue
+3
-3
app/assets/stylesheets/framework/dropdowns.scss
app/assets/stylesheets/framework/dropdowns.scss
+1
-0
spec/frontend/whats_new/components/trigger_spec.js
spec/frontend/whats_new/components/trigger_spec.js
+2
-2
No files found.
app/assets/javascripts/whats_new/components/trigger.vue
View file @
9214463a
<
script
>
<
script
>
import
{
mapActions
}
from
'
vuex
'
;
import
{
mapActions
}
from
'
vuex
'
;
import
{
Gl
Link
}
from
'
@gitlab/ui
'
;
import
{
Gl
Button
}
from
'
@gitlab/ui
'
;
export
default
{
export
default
{
components
:
{
components
:
{
Gl
Link
,
Gl
Button
,
},
},
methods
:
{
methods
:
{
...
mapActions
([
'
openDrawer
'
]),
...
mapActions
([
'
openDrawer
'
]),
...
@@ -14,6 +14,6 @@ export default {
...
@@ -14,6 +14,6 @@ export default {
<
template
>
<
template
>
<li>
<li>
<gl-
link
@
click=
"openDrawer"
>
{{
__
(
"
See what's new at GitLab
"
)
}}
</gl-link
>
<gl-
button
variant=
"link"
@
click=
"openDrawer"
>
{{
__
(
"
See what's new at GitLab
"
)
}}
</gl-button
>
</li>
</li>
</
template
>
</
template
>
app/assets/stylesheets/framework/dropdowns.scss
View file @
9214463a
...
@@ -312,6 +312,7 @@
...
@@ -312,6 +312,7 @@
>
a
,
>
a
,
button
,
button
,
.gl-button.btn-link
,
.menu-item
{
.menu-item
{
@include
dropdown-link
;
@include
dropdown-link
;
}
}
...
...
spec/frontend/whats_new/components/trigger_spec.js
View file @
9214463a
import
{
createLocalVue
,
mount
}
from
'
@vue/test-utils
'
;
import
{
createLocalVue
,
mount
}
from
'
@vue/test-utils
'
;
import
Vuex
from
'
vuex
'
;
import
Vuex
from
'
vuex
'
;
import
{
GlButton
}
from
'
@gitlab/ui
'
;
import
Trigger
from
'
~/whats_new/components/trigger.vue
'
;
import
Trigger
from
'
~/whats_new/components/trigger.vue
'
;
const
localVue
=
createLocalVue
();
const
localVue
=
createLocalVue
();
...
@@ -37,7 +37,7 @@ describe('Trigger', () => {
...
@@ -37,7 +37,7 @@ describe('Trigger', () => {
});
});
it
(
'
dispatches openDrawer when clicking close
'
,
()
=>
{
it
(
'
dispatches openDrawer when clicking close
'
,
()
=>
{
wrapper
.
find
(
'
a
'
).
trigger
(
'
click
'
);
wrapper
.
find
(
GlButton
).
vm
.
$emit
(
'
click
'
);
expect
(
actions
.
openDrawer
).
toHaveBeenCalled
();
expect
(
actions
.
openDrawer
).
toHaveBeenCalled
();
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment