Commit 931c8b80 authored by Mike Greiling's avatar Mike Greiling

Merge branch 'loadash_helpers' into 'master'

Chore: replace underscore with lodash for in /app/assets/javascripts/helpers

See merge request gitlab-org/gitlab!25014
parents d8ebcdb0 c6474446
import _ from 'underscore'; import { escape } from 'lodash';
import { getFirstCharacterCapitalized } from '~/lib/utils/text_utility'; import { getFirstCharacterCapitalized } from '~/lib/utils/text_utility';
export const DEFAULT_SIZE_CLASS = 's40'; export const DEFAULT_SIZE_CLASS = 's40';
...@@ -19,7 +19,7 @@ export function renderIdenticon(entity, options = {}) { ...@@ -19,7 +19,7 @@ export function renderIdenticon(entity, options = {}) {
const bgClass = getIdenticonBackgroundClass(entity.id); const bgClass = getIdenticonBackgroundClass(entity.id);
const title = getIdenticonTitle(entity.name); const title = getIdenticonTitle(entity.name);
return `<div class="avatar identicon ${_.escape(sizeClass)} ${_.escape(bgClass)}">${_.escape( return `<div class="avatar identicon ${escape(sizeClass)} ${escape(bgClass)}">${escape(
title, title,
)}</div>`; )}</div>`;
} }
...@@ -31,5 +31,5 @@ export function renderAvatar(entity, options = {}) { ...@@ -31,5 +31,5 @@ export function renderAvatar(entity, options = {}) {
const { sizeClass = DEFAULT_SIZE_CLASS } = options; const { sizeClass = DEFAULT_SIZE_CLASS } = options;
return `<img src="${_.escape(entity.avatar_url)}" class="avatar ${_.escape(sizeClass)}" />`; return `<img src="${escape(entity.avatar_url)}" class="avatar ${escape(sizeClass)}" />`;
} }
---
title: Replace underscore with lodash in /app/assets/javascripts/helpers
merge_request: 25014
author: rkpattnaik780
type: changed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment