Merge branch 'frozen-string-ee-lib-api' into 'master'

Enable some frozen string in ee/lib

See merge request gitlab-org/gitlab-ee!8930

ee/app/finders/parent_groups_finder.rb

+# frozen_string_literal: true
+
 class ParentGroupsFinder
   attr_accessor :user, :group
 

ee/app/models/ee/user_preference.rb

+# frozen_string_literal: true
+
 module EE
   module UserPreference
     extend ActiveSupport::Concern

ee/app/models/gitlab_subscription.rb

+# frozen_string_literal: true
+
 class GitlabSubscription < ActiveRecord::Base
   belongs_to :namespace
   belongs_to :hosted_plan, class_name: 'Plan'

ee/app/services/ee/projects/cleanup_service.rb

+# frozen_string_literal: true
+
 module EE
   module Projects
     module CleanupService

ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb

+# frozen_string_literal: true
+
 class UpdateMaxSeatsUsedForGitlabComSubscriptionsWorker
   include ApplicationWorker
   include CronjobQueue

ee/changelogs/unreleased/frozen-string-ee-lib-api.yml

+---
+title: Enable some frozen string in ee/lib
+merge_request:
+author: gfyoung
+type: performance

ee/lib/api/epic_issues.rb

+# frozen_string_literal: true
+
 module API
   class EpicIssues < Grape::API
     before do

ee/lib/api/epics.rb

+# frozen_string_literal: true
+
 module API
   class Epics < Grape::API
     before do

ee/lib/api/geo.rb

+# frozen_string_literal: true
+
 require 'base64'
 
 module API

ee/lib/api/geo_nodes.rb

+# frozen_string_literal: true
+
 module API
   class GeoNodes < Grape::API
     include PaginationParams

ee/lib/api/github/entities.rb

+# frozen_string_literal: true
+
 # Simplified version of Github API entities.
 # It's mainly used to mimic Github API and integrate with Jira Development Panel.
 #

ee/lib/api/issue_links.rb

+# frozen_string_literal: true
+
 module API
   class IssueLinks < Grape::API
     include PaginationParams

ee/lib/api/ldap.rb

+# frozen_string_literal: true
+
 module API
   class Ldap < Grape::API
     # Admin users by default should be able to access these API endpoints.

ee/lib/api/ldap_group_links.rb

+# frozen_string_literal: true
+
 module API
   class LdapGroupLinks < Grape::API
     before { authenticate! }

ee/lib/api/license.rb

+# frozen_string_literal: true
+
 module API
   class License < Grape::API
     before { authenticated_as_admin! }

ee/lib/api/merge_request_approvals.rb

+# frozen_string_literal: true
+
 module API
   class MergeRequestApprovals < ::Grape::API
     before { authenticate_non_get! }

ee/lib/api/project_approvals.rb

+# frozen_string_literal: true
+
 module API
   class ProjectApprovals < ::Grape::API
     before { authenticate! }

ee/lib/api/project_mirror.rb

+# frozen_string_literal: true
+
 require_dependency 'declarative_policy'
 
 module API

ee/lib/api/project_push_rule.rb

+# frozen_string_literal: true
+
 module API
   class ProjectPushRule < Grape::API
     before { authenticate! }

ee/lib/api/unleash.rb

+# frozen_string_literal: true
+
 module API
   class Unleash < Grape::API
     include PaginationParams

ee/lib/api/v3/github.rb

+# frozen_string_literal: true
+
 # These endpoints partially mimic Github API behavior in order to successfully
 # integrate with Jira Development Panel.
 # Endpoints returning an empty list were temporarily added to avoid 404's

ee/lib/audit/details.rb

+# frozen_string_literal: true
+
 module Audit
   class Details
     ACTIONS = %i[add remove failed_login change custom_message].freeze
@@ -39,10 +41,12 @@ module Audit
     end
 
     def text_for_change(value)
-      "Changed #{value}".tap do |changed_string|
-        changed_string << " from #{@details[:from]}" if @details[:from]
-        changed_string << " to #{@details[:to]}" if @details[:to]
-      end
+      changed = ["Changed #{value}"]
+
+      changed << "from #{@details[:from]}" if @details[:from]
+      changed << "to #{@details[:to]}" if @details[:to]
+
+      changed.join(' ')
     end
   end
 end

ee/lib/banzai/filter/cross_project_issuable_information_filter.rb

+# frozen_string_literal: true
+
 module Banzai
   module Filter
     # HTML filter that removes sensitive information from cross project

ee/lib/banzai/reference_parser/ee/base_parser.rb

+# frozen_string_literal: true
+
 module Banzai
   module ReferenceParser
     module EE

ee/lib/csv_builder.rb

+# frozen_string_literal: true
+
 # Generates CSV when given a collection and a mapping.
 #
 # Example:

ee/lib/delay.rb

+# frozen_string_literal: true
+
 module Delay
   # Progressive backoff. It's copied from Sidekiq as is
   def delay(retry_count = 0)

ee/lib/ee.rb

+# frozen_string_literal: true
+
 module EE
   SUBSCRIPTIONS_URL = 'https://customers.gitlab.com'.freeze
   SUBSCRIPTIONS_PLANS_URL = "#{SUBSCRIPTIONS_URL}/plans".freeze

ee/lib/ee/api/api_guard.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module APIGuard

ee/lib/ee/api/boards.rb

+# frozen_string_literal: true
+
 module EE
   module API
     class Boards < ::Grape::API

ee/lib/ee/api/boards_responses.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module BoardsResponses

ee/lib/ee/api/entities.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Entities

ee/lib/ee/api/group_boards.rb

+# frozen_string_literal: true
+
 module EE
   module API
     class GroupBoards < ::Grape::API

ee/lib/ee/api/helpers.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Helpers

ee/lib/ee/api/helpers/notes_helpers.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Helpers

ee/lib/ee/api/helpers/project_snapshots_helpers.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Helpers

ee/lib/ee/api/helpers/runner.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Helpers

ee/lib/ee/api/issues.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Issues

ee/lib/ee/api/job_artifacts.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module JobArtifacts

ee/lib/ee/api/merge_requests.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module MergeRequests

ee/lib/ee/api/namespaces.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Namespaces

ee/lib/ee/api/todos.rb

+# frozen_string_literal: true
+
 module EE
   module API
     module Todos

ee/lib/ee/audit/base_changes_auditor.rb

+# frozen_string_literal: true
+
 module EE
   module Audit
     class BaseChangesAuditor

ee/lib/ee/audit/changes.rb

+# frozen_string_literal: true
+
 module EE
   module Audit
     module Changes

ee/lib/ee/audit/group_changes_auditor.rb

+# frozen_string_literal: true
+
 module EE
   module Audit
     class GroupChangesAuditor < BaseChangesAuditor

ee/lib/ee/audit/project_changes_auditor.rb

+# frozen_string_literal: true
+
 module EE
   module Audit
     class ProjectChangesAuditor < BaseChangesAuditor

ee/lib/ee/banzai/filter/epic_reference_filter.rb

+# frozen_string_literal: true
+
 module EE
   module Banzai
     module Filter

ee/lib/ee/banzai/pipeline/gfm_pipeline.rb

+# frozen_string_literal: true
+
 module EE
   module Banzai
     module Pipeline

ee/lib/ee/banzai/pipeline/post_process_pipeline.rb

+# frozen_string_literal: true
+
 module EE
   module Banzai
     module Pipeline

ee/lib/ee/banzai/pipeline/single_line_pipeline.rb

+# frozen_string_literal: true
+
 module EE
   module Banzai
     module Pipeline

ee/lib/ee/banzai/reference_parser/epic_parser.rb

+# frozen_string_literal: true
+
 module EE
   module Banzai
     module ReferenceParser

ee/lib/ee/gitlab/access.rb

+# frozen_string_literal: true
+
 # Gitlab::Access module
 #
 # Define allowed roles that can be used

ee/lib/ee/gitlab/auth.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/access.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/access_levels.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/adapter.rb

+# frozen_string_literal: true
+
 # LDAP connection adapter EE mixin
 #
 # This module is intended to encapsulate EE-specific adapter methods

ee/lib/ee/gitlab/auth/ldap/config.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/group.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/person.rb

+# frozen_string_literal: true
+
 require 'net/ldap/dn'
 
 module EE

ee/lib/ee/gitlab/auth/ldap/sync/admin_users.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/sync/external_users.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/sync/group.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/sync/groups.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb

+# frozen_string_literal: true
+
 require 'net/ldap/dn'
 
 module EE

ee/lib/ee/gitlab/auth/ldap/sync/users.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/ldap/user.rb

+# frozen_string_literal: true
+
 # LDAP User EE mixin
 #
 # This module is intended to encapsulate EE-specific User methods

ee/lib/ee/gitlab/auth/ldap/user_filter.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/o_auth/auth_hash.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth
@@ -18,7 +20,7 @@ module EE
               # does not normalize them as of version 0.3.0, so add the default
               # realm ourselves if appropriate
               if provider == 'kerberos' && ee_uid.present?
-                ee_uid += "@#{kerberos_default_realm}" unless ee_uid.include?('@')
+                ee_uid = "#{ee_uid}@#{kerberos_default_realm}" unless ee_uid.include?('@')
               end
 
               ee_uid

ee/lib/ee/gitlab/auth/o_auth/user.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/result.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/saml/config.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/saml/user.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/auth/user_auth_finders.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Auth

ee/lib/ee/gitlab/ci/limit.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/ci/pipeline/chain/limit/activity.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/ci/pipeline/chain/limit/size.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/ci/pipeline/chain/remove_unwanted_chat_jobs.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/ci/pipeline/quota/activity.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/ci/pipeline/quota/size.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Ci

ee/lib/ee/gitlab/database.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Database

ee/lib/ee/gitlab/etag_caching/router.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module EtagCaching

ee/lib/ee/gitlab/external_authorization.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization

ee/lib/ee/gitlab/external_authorization/access.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization

ee/lib/ee/gitlab/external_authorization/cache.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization

ee/lib/ee/gitlab/external_authorization/client.rb

+# frozen_string_literal: true
+
 Excon.defaults[:ssl_verify_peer] = false
 
 module EE

ee/lib/ee/gitlab/external_authorization/config.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization

ee/lib/ee/gitlab/external_authorization/logger.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization
       class Logger < ::Gitlab::Logger
         def self.log_access(access, project_path)
           status = access.has_access? ? "GRANTED" : "DENIED"
-          message = "#{status} #{access.user.email} access to '#{access.label}'"
+          message = ["#{status} #{access.user.email} access to '#{access.label}'"]
 
-          message << " (#{project_path})" if project_path.present?
-          message << " - #{access.load_type} #{access.loaded_at}" if access.load_type == :cache
+          message << "(#{project_path})" if project_path.present?
+          message << "- #{access.load_type} #{access.loaded_at}" if access.load_type == :cache
 
-          info(message)
+          info(message.join(' '))
         end
 
         def self.file_name_noext

ee/lib/ee/gitlab/external_authorization/response.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ExternalAuthorization

ee/lib/ee/gitlab/geo_git_access.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module GeoGitAccess
@@ -50,7 +52,7 @@ module EE
         message = super
 
         if ::Gitlab::Geo.secondary_with_primary?
-          message += "\nPlease use the primary node URL instead: #{geo_primary_url_to_repo}.\nFor more information: #{GEO_SERVER_DOCS_URL}"
+          message = "#{message}\nPlease use the primary node URL instead: #{geo_primary_url_to_repo}.\nFor more information: #{GEO_SERVER_DOCS_URL}"
         end
 
         message

ee/lib/ee/gitlab/git_access.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module GitAccess

ee/lib/ee/gitlab/git_access_wiki.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module GitAccessWiki

ee/lib/ee/gitlab/github_import/parallel_importer.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module GithubImport

ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ImportExport

ee/lib/ee/gitlab/import_export/relation_factory.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ImportExport

ee/lib/ee/gitlab/import_sources.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module ImportSources

ee/lib/ee/gitlab/middleware/read_only/controller.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Middleware

ee/lib/ee/gitlab/omniauth_initializer.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module OmniauthInitializer

ee/lib/ee/gitlab/prometheus/metric_group.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Prometheus

ee/lib/ee/gitlab/prometheus/queries/query_additional_metrics.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Prometheus

ee/lib/ee/gitlab/rack/attack/request.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Rack

ee/lib/ee/gitlab/regex.rb

+# frozen_string_literal: true
+
 module EE
   module Gitlab
     module Regex