Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9433ae8f
Commit
9433ae8f
authored
Aug 21, 2019
by
Heinrich Lee Yu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Include ancestor group labels in autocomplete
Fixes existing spec that wasn't testing what it was supposed to
parent
744c0166
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
ee/app/services/groups/autocomplete_service.rb
ee/app/services/groups/autocomplete_service.rb
+1
-1
ee/changelogs/unreleased/10706-quick-actions-on-epic-doesn-t-include-ancestor-group-labels.yml
...actions-on-epic-doesn-t-include-ancestor-group-labels.yml
+5
-0
ee/spec/services/groups/autocomplete_service_spec.rb
ee/spec/services/groups/autocomplete_service_spec.rb
+1
-1
No files found.
ee/app/services/groups/autocomplete_service.rb
View file @
9433ae8f
...
@@ -43,7 +43,7 @@ module Groups
...
@@ -43,7 +43,7 @@ module Groups
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: enable CodeReuse/ActiveRecord
def
labels_as_hash
(
target
)
def
labels_as_hash
(
target
)
super
(
target
,
group_id:
group
.
id
,
only_group_labels:
true
)
super
(
target
,
group_id:
group
.
id
,
only_group_labels:
true
,
include_ancestor_groups:
true
)
end
end
def
commands
(
noteable
)
def
commands
(
noteable
)
...
...
ee/changelogs/unreleased/10706-quick-actions-on-epic-doesn-t-include-ancestor-group-labels.yml
0 → 100644
View file @
9433ae8f
---
title
:
Include ancestor group labels in autocomplete for epics
merge_request
:
15460
author
:
type
:
fixed
ee/spec/services/groups/autocomplete_service_spec.rb
View file @
9433ae8f
...
@@ -21,7 +21,7 @@ describe Groups::AutocompleteService do
...
@@ -21,7 +21,7 @@ describe Groups::AutocompleteService do
let!
(
:label1
)
{
create
(
:group_label
,
group:
group
)
}
let!
(
:label1
)
{
create
(
:group_label
,
group:
group
)
}
let!
(
:label2
)
{
create
(
:group_label
,
group:
group
)
}
let!
(
:label2
)
{
create
(
:group_label
,
group:
group
)
}
let!
(
:sub_group_label
)
{
create
(
:group_label
,
group:
sub_group
)
}
let!
(
:sub_group_label
)
{
create
(
:group_label
,
group:
sub_group
)
}
let!
(
:parent_group_label
)
{
create
(
:group_label
,
group:
group
.
parent
,
group_id:
group
.
id
)
}
let!
(
:parent_group_label
)
{
create
(
:group_label
,
group:
group
.
parent
)
}
it
'returns labels from own group and ancestor groups'
do
it
'returns labels from own group and ancestor groups'
do
results
=
subject
.
labels_as_hash
(
nil
)
results
=
subject
.
labels_as_hash
(
nil
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment