Experiment - reCAPTCHA for sign up

This allows a newly registered user to be logged
with the state of the experiment_growth_recaptcha
experiment.

app/controllers/registrations_controller.rb

@@ -3,6 +3,7 @@
 class RegistrationsController < Devise::RegistrationsController
   include Recaptcha::Verify
   include AcceptsPendingInvitations
+  include RecaptchaExperimentHelper
 
   prepend_before_action :check_captcha, only: :create
   before_action :whitelist_query_limiting, only: [:destroy]
@@ -95,6 +96,7 @@ class RegistrationsController < Devise::RegistrationsController
     ensure_correct_params!
 
     return unless Feature.enabled?(:registrations_recaptcha, default_enabled: true) # reCAPTCHA on the UI will still display however
+    return unless show_recaptcha_sign_up?
     return unless Gitlab::Recaptcha.load_configurations!
 
     return if verify_recaptcha

app/views/devise/shared/_signup_box.html.haml

@@ -33,7 +33,7 @@
             = accept_terms_label.html_safe
       = render_if_exists 'devise/shared/email_opted_in', f: f
       %div
-      - if Gitlab::Recaptcha.enabled?
+      - if show_recaptcha_sign_up?
         = recaptcha_tags
       .submit-container
         = f.submit _("Register"), class: "btn-register btn qa-new-user-register-button"

ee/app/controllers/ee/registrations_controller.rb

@@ -3,9 +3,17 @@
 module EE
   module RegistrationsController
     extend ActiveSupport::Concern
+    extend ::Gitlab::Utils::Override
 
     private
 
+    override :user_created_message
+    def user_created_message(confirmed: false)
+      experiments = "experiment_growth_recaptcha?#{show_recaptcha_sign_up?}"
+
+      super(confirmed: confirmed) + ", experiments:#{experiments}"
+    end
+
     def sign_up_params
       clean_params = params.require(:user).permit(:username, :email, :email_confirmation, :name, :password, :email_opted_in)
 

ee/spec/controllers/registrations_controller_spec.rb

@@ -27,5 +27,16 @@ describe RegistrationsController do
         expect(user.email_opted_in_at).to be_nil
       end
     end
+
+    context 'when recaptcha experiment enabled' do
+      it "logs a 'User Created' message including the experiment state" do
+        user_params = { user: attributes_for(:user) }
+        allow_any_instance_of(EE::RecaptchaExperimentHelper).to receive(:show_recaptcha_sign_up?).and_return(true)
+
+        expect(Gitlab::AppLogger).to receive(:info).with(/\AUser Created: .+experiment_growth_recaptcha\?true\z/).and_call_original
+
+        post :create, params: user_params
+      end
+    end
   end
 end

spec/controllers/registrations_controller_spec.rb

@@ -107,6 +107,14 @@ describe RegistrationsController do
       end
     end
 
+    it "logs a 'User Created' message" do
+      stub_feature_flags(registrations_recaptcha: false)
+
+      expect(Gitlab::AppLogger).to receive(:info).with(/\AUser Created: username=new_username email=new@user.com.+\z/).and_call_original
+
+      post(:create, params: user_params)
+    end
+
     it 'handles when params are new_user' do
       post(:create, params: { new_user: base_user_params })