Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
94e0ca00
Commit
94e0ca00
authored
Jul 21, 2016
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow GFM autocomplete to be trigger without the preceding space
Closes #19975
parent
8ed97054
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
30 additions
and
0 deletions
+30
-0
app/assets/javascripts/gfm_auto_complete.js.coffee
app/assets/javascripts/gfm_auto_complete.js.coffee
+6
-0
spec/features/issues/gfm_autocomplete_spec.rb
spec/features/issues/gfm_autocomplete_spec.rb
+24
-0
No files found.
app/assets/javascripts/gfm_auto_complete.js.coffee
View file @
94e0ca00
...
...
@@ -84,6 +84,7 @@ GitLab.GfmAutoComplete =
@
Loading
.
template
insertTpl
:
':${name}:'
data
:
[
'loading'
]
startWithSpace
:
false
callbacks
:
sorter
:
@
DefaultOptions
.
sorter
filter
:
@
DefaultOptions
.
filter
...
...
@@ -100,6 +101,7 @@ GitLab.GfmAutoComplete =
insertTpl
:
'${atwho-at}${username}'
searchKey
:
'search'
data
:
[
'loading'
]
startWithSpace
:
false
callbacks
:
sorter
:
@
DefaultOptions
.
sorter
filter
:
@
DefaultOptions
.
filter
...
...
@@ -126,6 +128,7 @@ GitLab.GfmAutoComplete =
@
Loading
.
template
data
:
[
'loading'
]
insertTpl
:
'${atwho-at}${id}'
startWithSpace
:
false
callbacks
:
sorter
:
@
DefaultOptions
.
sorter
filter
:
@
DefaultOptions
.
filter
...
...
@@ -149,6 +152,7 @@ GitLab.GfmAutoComplete =
@
Loading
.
template
insertTpl
:
'${atwho-at}"${title}"'
data
:
[
'loading'
]
startWithSpace
:
false
callbacks
:
beforeSave
:
(
milestones
)
->
$
.
map
milestones
,
(
m
)
->
...
...
@@ -169,6 +173,7 @@ GitLab.GfmAutoComplete =
@
Loading
.
template
data
:
[
'loading'
]
insertTpl
:
'${atwho-at}${id}'
startWithSpace
:
false
callbacks
:
sorter
:
@
DefaultOptions
.
sorter
filter
:
@
DefaultOptions
.
filter
...
...
@@ -187,6 +192,7 @@ GitLab.GfmAutoComplete =
searchKey
:
'search'
displayTpl
:
@
Labels
.
template
insertTpl
:
'${atwho-at}${title}'
startWithSpace
:
false
callbacks
:
beforeSave
:
(
merges
)
->
sanitizeLabelTitle
=
(
title
)
->
...
...
spec/features/issues/gfm_autocomplete_spec.rb
0 → 100644
View file @
94e0ca00
require
'rails_helper'
feature
'GFM autocomplete'
,
feature:
true
,
js:
true
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
)
}
before
do
project
.
team
<<
[
user
,
:master
]
login_as
(
user
)
visit
namespace_project_issue_path
(
project
.
namespace
,
project
,
issue
)
end
it
'opens autocomplete menu when doesnt starts with space'
do
sleep
2
page
.
within
'.timeline-content-form'
do
find
(
'#note_note'
).
native
.
send_keys
(
'testing'
)
find
(
'#note_note'
).
native
.
send_keys
(
'@'
)
end
expect
(
page
).
to
have_selector
(
'.atwho-view'
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment