Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
95cd4799
Commit
95cd4799
authored
Dec 10, 2018
by
Tim Zallmann
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed UserPopover Conflicts
parent
42e00f75
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
0 additions
and
34 deletions
+0
-34
app/assets/javascripts/main.js
app/assets/javascripts/main.js
+0
-3
app/assets/javascripts/notes/components/note_header.vue
app/assets/javascripts/notes/components/note_header.vue
+0
-3
app/assets/javascripts/user_popovers.js
app/assets/javascripts/user_popovers.js
+0
-14
app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
...ripts/vue_shared/components/user_popover/user_popover.vue
+0
-7
spec/javascripts/api_spec.js
spec/javascripts/api_spec.js
+0
-3
spec/javascripts/user_popovers_spec.js
spec/javascripts/user_popovers_spec.js
+0
-4
No files found.
app/assets/javascripts/main.js
View file @
95cd4799
...
...
@@ -31,12 +31,9 @@ import initPerformanceBar from './performance_bar';
import
initSearchAutocomplete
from
'
./search_autocomplete
'
;
import
GlFieldErrors
from
'
./gl_field_errors
'
;
import
initUserPopovers
from
'
./user_popovers
'
;
<<<<<<<
HEAD
// EE-only scripts
import
'
ee/main
'
;
=======
>>>>>>>
upstream
/
master
// expose jQuery as global (TODO: remove these)
window
.
jQuery
=
jQuery
;
...
...
app/assets/javascripts/notes/components/note_header.vue
View file @
95cd4799
...
...
@@ -81,10 +81,7 @@ export default {
:data-user-id=
"author.id"
:data-username=
"author.username"
>
<<<<<<<
HEAD
<slot
name=
"note-header-info"
></slot>
=======
>>>>>>> upstream/master
<span
class=
"note-header-author-name"
>
{{
author
.
name
}}
</span>
<span
v-if=
"author.status_tooltip_html"
v-html=
"author.status_tooltip_html"
></span>
<span
class=
"note-headline-light"
>
@
{{
author
.
username
}}
</span>
...
...
app/assets/javascripts/user_popovers.js
View file @
95cd4799
...
...
@@ -47,10 +47,7 @@ const handleUserPopoverMouseOver = event => {
bio
:
null
,
organization
:
null
,
status
:
null
,
<<<<<<<
HEAD
=======
loaded
:
false
,
>>>>>>>
upstream
/
master
};
if
(
userId
||
username
)
{
const
UserPopoverComponent
=
Vue
.
extend
(
UserPopover
);
...
...
@@ -98,22 +95,11 @@ const handleUserPopoverMouseOver = event => {
renderedPopover
=
null
;
});
}
<<<<<<<
HEAD
},
200
);
};
export
default
elements
=>
{
let
userLinks
=
elements
;
if
(
!
elements
)
{
userLinks
=
[...
document
.
querySelectorAll
(
'
.js-user-link
'
)];
}
=======
},
200
);
// 200ms delay so not every mouseover triggers Popover + API Call
};
export
default
elements
=>
{
const
userLinks
=
elements
||
[...
document
.
querySelectorAll
(
'
.js-user-link
'
)];
>>>>>>>
upstream
/
master
userLinks
.
forEach
(
el
=>
{
el
.
addEventListener
(
'
mouseenter
'
,
handleUserPopoverMouseOver
);
...
...
app/assets/javascripts/vue_shared/components/user_popover/user_popover.vue
View file @
95cd4799
...
...
@@ -53,17 +53,10 @@ export default {
return
!
this
.
user
.
name
;
},
jobInfoIsLoading
()
{
<<<<<<<
HEAD
return
!
this
.
loaded
&&
this
.
user
.
organization
===
null
;
},
locationIsLoading
()
{
return
!
this
.
loaded
&&
this
.
user
.
location
===
null
;
=======
return
!
this
.
user
.
loaded
&&
this
.
user
.
organization
===
null
;
},
locationIsLoading
()
{
return
!
this
.
user
.
loaded
&&
this
.
user
.
location
===
null
;
>>>>>>>
upstream
/
master
},
},
};
...
...
spec/javascripts/api_spec.js
View file @
95cd4799
...
...
@@ -333,7 +333,6 @@ describe('Api', () => {
});
});
<<<<<<<
HEAD
describe
(
'
ldap_groups
'
,
()
=>
{
it
(
'
calls callback on completion
'
,
done
=>
{
const
query
=
'
query
'
;
...
...
@@ -356,8 +355,6 @@ describe('Api', () => {
});
});
=======
>>>>>>>
upstream
/
master
describe
(
'
user
'
,
()
=>
{
it
(
'
fetches single user
'
,
done
=>
{
const
userId
=
'
123456
'
;
...
...
spec/javascripts/user_popovers_spec.js
View file @
95cd4799
...
...
@@ -48,11 +48,7 @@ describe('User Popovers', () => {
expect
(
document
.
querySelector
(
'
.popover
'
)).
toBeNull
();
done
();
});
<<<<<<<
HEAD
},
210
);
=======
},
210
);
// We need to wait until the 200ms mouseover delay is over, only then the popover will be visible
>>>>>>>
upstream
/
master
});
it
(
'
Should Not show a popover on short mouse over
'
,
done
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment