Commit 96b2ed05 authored by Arturo Herrero's avatar Arturo Herrero

Use let_it_be instead of let!

parent 259b0eb1
......@@ -600,15 +600,15 @@ RSpec.describe Service do
end
describe '.inherited_descendants_from_self_or_ancestors_from' do
let(:subgroup1) { create(:group, parent: group) }
let(:subgroup2) { create(:group, parent: group) }
let(:project1) { create(:project, group: subgroup1) }
let(:project2) { create(:project, group: subgroup2) }
let!(:group_integration) { create(:prometheus_service, group: group, project: nil) }
let!(:subgroup_integration1) { create(:prometheus_service, group: subgroup1, project: nil, inherit_from_id: group_integration.id) }
let!(:subgroup_integration2) { create(:prometheus_service, group: subgroup2, project: nil) }
let!(:project_integration1) { create(:prometheus_service, group: nil, project: project1, inherit_from_id: group_integration.id) }
let!(:project_integration2) { create(:prometheus_service, group: nil, project: project2, inherit_from_id: subgroup_integration2.id) }
let_it_be(:subgroup1) { create(:group, parent: group) }
let_it_be(:subgroup2) { create(:group, parent: group) }
let_it_be(:project1) { create(:project, group: subgroup1) }
let_it_be(:project2) { create(:project, group: subgroup2) }
let_it_be(:group_integration) { create(:prometheus_service, group: group, project: nil) }
let_it_be(:subgroup_integration1) { create(:prometheus_service, group: subgroup1, project: nil, inherit_from_id: group_integration.id) }
let_it_be(:subgroup_integration2) { create(:prometheus_service, group: subgroup2, project: nil) }
let_it_be(:project_integration1) { create(:prometheus_service, group: nil, project: project1, inherit_from_id: group_integration.id) }
let_it_be(:project_integration2) { create(:prometheus_service, group: nil, project: project2, inherit_from_id: subgroup_integration2.id) }
it 'returns the groups and projects inheriting from integration ancestors', :aggregate_failures do
expect(described_class.inherited_descendants_from_self_or_ancestors_from(group_integration)).to eq([subgroup_integration1, project_integration1])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment