Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
988f276a
Commit
988f276a
authored
Dec 08, 2020
by
peterhegman
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Default `group_members_filtered_search` FF to `on`
Default `group_members_filtered_search` feature flag to `on`
parent
7b4ef3d2
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
3 deletions
+8
-3
app/controllers/groups/group_members_controller.rb
app/controllers/groups/group_members_controller.rb
+1
-1
app/views/groups/group_members/index.html.haml
app/views/groups/group_members/index.html.haml
+1
-1
changelogs/unreleased/289911-feature-flag-rollout-of-group_members_filtered_search.yml
...feature-flag-rollout-of-group_members_filtered_search.yml
+5
-0
config/feature_flags/development/group_members_filtered_search.yml
...ature_flags/development/group_members_filtered_search.yml
+1
-1
No files found.
app/controllers/groups/group_members_controller.rb
View file @
988f276a
...
@@ -15,7 +15,7 @@ class Groups::GroupMembersController < Groups::ApplicationController
...
@@ -15,7 +15,7 @@ class Groups::GroupMembersController < Groups::ApplicationController
before_action
:authorize_admin_group_member!
,
except:
admin_not_required_endpoints
before_action
:authorize_admin_group_member!
,
except:
admin_not_required_endpoints
before_action
do
before_action
do
push_frontend_feature_flag
(
:group_members_filtered_search
,
@group
)
push_frontend_feature_flag
(
:group_members_filtered_search
,
@group
,
default_enabled:
true
)
end
end
skip_before_action
:check_two_factor_requirement
,
only: :leave
skip_before_action
:check_two_factor_requirement
,
only: :leave
...
...
app/views/groups/group_members/index.html.haml
View file @
988f276a
...
@@ -4,7 +4,7 @@
...
@@ -4,7 +4,7 @@
-
show_access_requests
=
can_manage_members
&&
@requesters
.
exists?
-
show_access_requests
=
can_manage_members
&&
@requesters
.
exists?
-
invited_active
=
params
[
:search_invited
].
present?
||
params
[
:invited_members_page
].
present?
-
invited_active
=
params
[
:search_invited
].
present?
||
params
[
:invited_members_page
].
present?
-
vue_members_list_enabled
=
Feature
.
enabled?
(
:vue_group_members_list
,
@group
,
default_enabled:
true
)
-
vue_members_list_enabled
=
Feature
.
enabled?
(
:vue_group_members_list
,
@group
,
default_enabled:
true
)
-
filtered_search_enabled
=
Feature
.
enabled?
(
:group_members_filtered_search
,
@group
)
-
filtered_search_enabled
=
Feature
.
enabled?
(
:group_members_filtered_search
,
@group
,
default_enabled:
true
)
-
current_user_is_group_owner
=
@group
&&
@group
.
has_owner?
(
current_user
)
-
current_user_is_group_owner
=
@group
&&
@group
.
has_owner?
(
current_user
)
-
form_item_label_css_class
=
'label-bold gl-mr-2 gl-mb-0 gl-py-2 align-self-md-center'
-
form_item_label_css_class
=
'label-bold gl-mr-2 gl-mb-0 gl-py-2 align-self-md-center'
...
...
changelogs/unreleased/289911-feature-flag-rollout-of-group_members_filtered_search.yml
0 → 100644
View file @
988f276a
---
title
:
Convert group member filter dropdowns to filtered search bar
merge_request
:
49505
author
:
type
:
changed
config/feature_flags/development/group_members_filtered_search.yml
View file @
988f276a
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/289911
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/289911
milestone
:
'
13.7'
milestone
:
'
13.7'
type
:
development
type
:
development
group
:
group::access
group
:
group::access
default_enabled
:
fals
e
default_enabled
:
tru
e
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment