Merge branch 'winh-eslint-promise/valid-params' into 'master'

Enable promise/valid-params ESLint rule

See merge request gitlab-org/gitlab!17628

.eslintrc.yml

@@ -46,7 +46,6 @@ rules:
   promise/always-return: off
   promise/no-callback-in-promise: off
   promise/no-nesting: off
-  promise/valid-params: off
 overrides:
   files:
     - '**/spec/**/*'

ee/spec/javascripts/vue_shared/security_reports/grouped_security_reports_app_spec.js

@@ -78,7 +78,7 @@ describe('Grouped security reports app', () => {
         waitForMutation(vm.$store, types.RECEIVE_DEPENDENCY_SCANNING_ERROR),
       ])
         .then(done)
-        .catch();
+        .catch(done.fail);
     });
 
     it('renders error state', () => {
@@ -192,7 +192,7 @@ describe('Grouped security reports app', () => {
         waitForMutation(vm.$store, types.RECEIVE_DEPENDENCY_SCANNING_REPORTS),
       ])
         .then(done)
-        .catch();
+        .catch(done.fail);
     });
 
     it('renders reports', () => {
@@ -355,7 +355,7 @@ describe('Grouped security reports app', () => {
 
         waitForMutation(vm.$store, types.RECEIVE_DEPENDENCY_SCANNING_DIFF_SUCCESS)
           .then(done)
-          .catch();
+          .catch(done.fail);
       });
 
       it('should set setDependencyScanningDiffEndpoint', () => {