Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9acd9885
Commit
9acd9885
authored
Aug 10, 2020
by
Jeremy Elder
Committed by
Kushal Pandya
Aug 10, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Replace GlDeprecatedButton with GlButton in requirement_form.vue
parent
7f9af793
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
8 deletions
+19
-8
ee/app/assets/javascripts/requirements/components/requirement_form.vue
.../javascripts/requirements/components/requirement_form.vue
+13
-7
ee/changelogs/unreleased/219863-replace-gl-deprecated-button-with-gl-button-in-ee-app-assets-ja.yml
...-deprecated-button-with-gl-button-in-ee-app-assets-ja.yml
+5
-0
ee/spec/features/projects/requirements_management/requirements_list_spec.rb
...rojects/requirements_management/requirements_list_spec.rb
+1
-1
No files found.
ee/app/assets/javascripts/requirements/components/requirement_form.vue
View file @
9acd9885
<
script
>
<
script
>
import
{
GlDrawer
,
GlFormGroup
,
GlFormTextarea
,
Gl
Deprecated
Button
}
from
'
@gitlab/ui
'
;
import
{
GlDrawer
,
GlFormGroup
,
GlFormTextarea
,
GlButton
}
from
'
@gitlab/ui
'
;
import
{
isEmpty
}
from
'
lodash
'
;
import
{
isEmpty
}
from
'
lodash
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
import
{
__
,
sprintf
}
from
'
~/locale
'
;
...
@@ -13,7 +13,7 @@ export default {
...
@@ -13,7 +13,7 @@ export default {
GlDrawer
,
GlDrawer
,
GlFormGroup
,
GlFormGroup
,
GlFormTextarea
,
GlFormTextarea
,
Gl
Deprecated
Button
,
GlButton
,
},
},
props
:
{
props
:
{
drawerOpen
:
{
drawerOpen
:
{
...
@@ -117,18 +117,24 @@ export default {
...
@@ -117,18 +117,24 @@ export default {
/>
/>
</gl-form-group>
</gl-form-group>
<div
class=
"d-flex requirement-form-actions"
>
<div
class=
"d-flex requirement-form-actions"
>
<gl-
deprecated-
button
<gl-button
:disabled=
"disableSaveButton"
:disabled=
"disableSaveButton"
:loading=
"requirementRequestActive"
:loading=
"requirementRequestActive"
category=
"primary"
variant=
"success"
variant=
"success"
category=
"primary"
class=
"mr-auto js-requirement-save"
class=
"mr-auto js-requirement-save"
@
click=
"handleSave"
@
click=
"handleSave"
>
{{
saveButtonLabel
}}
</gl-deprecated-button
>
>
<gl-deprecated-button
class=
"js-requirement-cancel"
@
click=
"$emit('cancel')"
>
{{
saveButtonLabel
}}
</gl-button>
<gl-button
variant=
"default"
category=
"primary"
class=
"js-requirement-cancel"
@
click=
"$emit('cancel')"
>
{{
__
(
'
Cancel
'
)
}}
{{
__
(
'
Cancel
'
)
}}
</gl-
deprecated-
button>
</gl-button>
</div>
</div>
</div>
</div>
</div>
</div>
...
...
ee/changelogs/unreleased/219863-replace-gl-deprecated-button-with-gl-button-in-ee-app-assets-ja.yml
0 → 100644
View file @
9acd9885
---
title
:
Replace GlDeprecatedButton with GlButton in Requirements form
merge_request
:
38422
author
:
type
:
other
ee/spec/features/projects/requirements_management/requirements_list_spec.rb
View file @
9acd9885
...
@@ -157,7 +157,7 @@ RSpec.describe 'Requirements list', :js do
...
@@ -157,7 +157,7 @@ RSpec.describe 'Requirements list', :js do
end
end
page
.
within
(
'.requirement-form'
)
do
page
.
within
(
'.requirement-form'
)
do
expect
(
page
.
find
(
'span'
)).
to
have_content
(
"REQ-
#{
requirement1
.
iid
}
"
)
expect
(
page
.
find
(
'span'
,
match: :first
)).
to
have_content
(
"REQ-
#{
requirement1
.
iid
}
"
)
expect
(
page
.
find
(
'textarea#requirementTitle'
)[
'value'
]).
to
have_content
(
"
#{
requirement1
.
title
}
"
)
expect
(
page
.
find
(
'textarea#requirementTitle'
)[
'value'
]).
to
have_content
(
"
#{
requirement1
.
title
}
"
)
expect
(
page
.
find
(
'.js-requirement-save'
)).
to
have_content
(
'Save changes'
)
expect
(
page
.
find
(
'.js-requirement-save'
)).
to
have_content
(
'Save changes'
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment