Commit 9b0eecd8 authored by Sean McGivern's avatar Sean McGivern

Add feature categories to controllers beginning with B

parent 1f5b0c38
...@@ -21,6 +21,8 @@ module Boards ...@@ -21,6 +21,8 @@ module Boards
before_action :validate_id_list, only: [:bulk_move] before_action :validate_id_list, only: [:bulk_move]
before_action :can_move_issues?, only: [:bulk_move] before_action :can_move_issues?, only: [:bulk_move]
feature_category :boards, only: [:index, :create, :bulk_move, :update]
def index def index
list_service = Boards::Issues::ListService.new(board_parent, current_user, filter_params) list_service = Boards::Issues::ListService.new(board_parent, current_user, filter_params)
issues = issues_from(list_service) issues = issues_from(list_service)
......
...@@ -8,6 +8,8 @@ module Boards ...@@ -8,6 +8,8 @@ module Boards
before_action :authorize_read_list, only: [:index] before_action :authorize_read_list, only: [:index]
skip_before_action :authenticate_user!, only: [:index] skip_before_action :authenticate_user!, only: [:index]
feature_category :boards, only: [:index, :create, :update, :destroy, :generate]
def index def index
lists = Boards::Lists::ListService.new(board.resource_parent, current_user).execute(board) lists = Boards::Lists::ListService.new(board.resource_parent, current_user).execute(board)
......
...@@ -5,6 +5,7 @@ module Boards ...@@ -5,6 +5,7 @@ module Boards
include BoardsResponses include BoardsResponses
before_action :authorize_read_milestone, only: [:index] before_action :authorize_read_milestone, only: [:index]
feature_category :boards, only: [:index]
def index def index
milestones_finder = Boards::MilestonesFinder.new(board, current_user) milestones_finder = Boards::MilestonesFinder.new(board, current_user)
......
...@@ -11,6 +11,7 @@ module Boards ...@@ -11,6 +11,7 @@ module Boards
include BoardsResponses include BoardsResponses
before_action :authorize_read_parent, only: [:index] before_action :authorize_read_parent, only: [:index]
feature_category :boards, only: [:index]
def index def index
user_ids = user_finder.execute.select(:user_id) user_ids = user_finder.execute.select(:user_id)
......
...@@ -22,15 +22,15 @@ RSpec.describe "Every controller" do ...@@ -22,15 +22,15 @@ RSpec.describe "Every controller" do
let_it_be(:routes_without_category) do let_it_be(:routes_without_category) do
controller_actions.map do |controller, action| controller_actions.map do |controller, action|
"#{controller}##{action}" unless controller.feature_category_for_action(action) next if controller.feature_category_for_action(action)
next unless controller.to_s.start_with?('B')
"#{controller}##{action}"
end.compact end.compact
end end
it "has feature categories" do it "has feature categories" do
pending("We'll work on defining categories for all controllers: "\ expect(routes_without_category).to be_empty, "#{routes_without_category} did not have a category"
"https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/463")
expect(routes_without_category).to be_empty, "#{routes_without_category.first(10)} did not have a category"
end end
it "completed controllers don't get new routes without categories" do it "completed controllers don't get new routes without categories" do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment