Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9b2eecb5
Commit
9b2eecb5
authored
Apr 10, 2021
by
Huzaifa Iftikhar
Committed by
David O'Regan
Apr 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/jira_import
parent
3c2c533b
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
8 additions
and
3 deletions
+8
-3
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-3
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-jira-import.yml
...836-fix-empty-line-after-let-it-be-gitlab-jira-import.yml
+5
-0
spec/lib/gitlab/jira_import/base_importer_spec.rb
spec/lib/gitlab/jira_import/base_importer_spec.rb
+1
-0
spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
+1
-0
spec/lib/gitlab/jira_import_spec.rb
spec/lib/gitlab/jira_import_spec.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
9b2eecb5
...
@@ -802,9 +802,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
...
@@ -802,9 +802,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
spec/lib/gitlab/hook_data/issue_builder_spec.rb
-
spec/lib/gitlab/hook_data/issue_builder_spec.rb
-
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
-
spec/lib/gitlab/hook_data/merge_request_builder_spec.rb
-
spec/lib/gitlab/hook_data/release_builder_spec.rb
-
spec/lib/gitlab/hook_data/release_builder_spec.rb
-
spec/lib/gitlab/jira_import/base_importer_spec.rb
-
spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
-
spec/lib/gitlab/jira_import_spec.rb
-
spec/lib/gitlab/json_cache_spec.rb
-
spec/lib/gitlab/json_cache_spec.rb
-
spec/lib/gitlab/language_detection_spec.rb
-
spec/lib/gitlab/language_detection_spec.rb
-
spec/lib/gitlab/project_search_results_spec.rb
-
spec/lib/gitlab/project_search_results_spec.rb
...
...
changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-jira-import.yml
0 → 100644
View file @
9b2eecb5
---
title
:
Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/jira_import
merge_request
:
58266
author
:
Huzaifa Iftikhar @huzaifaiftikhar
type
:
fixed
spec/lib/gitlab/jira_import/base_importer_spec.rb
View file @
9b2eecb5
...
@@ -27,6 +27,7 @@ RSpec.describe Gitlab::JiraImport::BaseImporter do
...
@@ -27,6 +27,7 @@ RSpec.describe Gitlab::JiraImport::BaseImporter do
context
'when import data exists'
do
context
'when import data exists'
do
let_it_be
(
:project
)
{
create
(
:project
)
}
let_it_be
(
:project
)
{
create
(
:project
)
}
let_it_be
(
:jira_import
)
{
create
(
:jira_import_state
,
project:
project
)
}
let_it_be
(
:jira_import
)
{
create
(
:jira_import_state
,
project:
project
)
}
let
(
:subject
)
{
described_class
.
new
(
project
)
}
let
(
:subject
)
{
described_class
.
new
(
project
)
}
context
'when #imported_items_cache_key is not implemented'
do
context
'when #imported_items_cache_key is not implemented'
do
...
...
spec/lib/gitlab/jira_import/handle_labels_service_spec.rb
View file @
9b2eecb5
...
@@ -10,6 +10,7 @@ RSpec.describe Gitlab::JiraImport::HandleLabelsService do
...
@@ -10,6 +10,7 @@ RSpec.describe Gitlab::JiraImport::HandleLabelsService do
let_it_be
(
:project_label
)
{
create
(
:label
,
project:
project
,
title:
'bug'
)
}
let_it_be
(
:project_label
)
{
create
(
:label
,
project:
project
,
title:
'bug'
)
}
let_it_be
(
:other_project_label
)
{
create
(
:label
,
title:
'feature'
)
}
let_it_be
(
:other_project_label
)
{
create
(
:label
,
title:
'feature'
)
}
let_it_be
(
:group_label
)
{
create
(
:group_label
,
group:
group
,
title:
'dev'
)
}
let_it_be
(
:group_label
)
{
create
(
:group_label
,
group:
group
,
title:
'dev'
)
}
let
(
:jira_labels
)
{
%w(bug feature dev group::new)
}
let
(
:jira_labels
)
{
%w(bug feature dev group::new)
}
subject
{
described_class
.
new
(
project
,
jira_labels
).
execute
}
subject
{
described_class
.
new
(
project
,
jira_labels
).
execute
}
...
...
spec/lib/gitlab/jira_import_spec.rb
View file @
9b2eecb5
...
@@ -9,6 +9,7 @@ RSpec.describe Gitlab::JiraImport do
...
@@ -9,6 +9,7 @@ RSpec.describe Gitlab::JiraImport do
include
JiraServiceHelper
include
JiraServiceHelper
let_it_be
(
:project
,
reload:
true
)
{
create
(
:project
)
}
let_it_be
(
:project
,
reload:
true
)
{
create
(
:project
)
}
let
(
:additional_params
)
{
{}
}
let
(
:additional_params
)
{
{}
}
subject
{
described_class
.
validate_project_settings!
(
project
,
**
additional_params
)
}
subject
{
described_class
.
validate_project_settings!
(
project
,
**
additional_params
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment