Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9cb4a728
Commit
9cb4a728
authored
May 13, 2020
by
Doug Stull
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve shared example newline offenses
- backlog after turning on
parent
a87025cd
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
21 additions
and
11 deletions
+21
-11
.rubocop_todo.yml
.rubocop_todo.yml
+0
-11
ee/spec/mailers/notify_spec.rb
ee/spec/mailers/notify_spec.rb
+4
-0
ee/spec/services/quick_actions/interpret_service_spec.rb
ee/spec/services/quick_actions/interpret_service_spec.rb
+2
-0
spec/controllers/repositories/git_http_controller_spec.rb
spec/controllers/repositories/git_http_controller_spec.rb
+3
-0
spec/finders/projects/serverless/functions_finder_spec.rb
spec/finders/projects/serverless/functions_finder_spec.rb
+1
-0
spec/lib/gitlab/hook_data/issuable_builder_spec.rb
spec/lib/gitlab/hook_data/issuable_builder_spec.rb
+1
-0
spec/lib/gitlab/legacy_github_import/importer_spec.rb
spec/lib/gitlab/legacy_github_import/importer_spec.rb
+1
-0
spec/models/event_spec.rb
spec/models/event_spec.rb
+8
-0
spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb
...red_examples/models/issuable_hook_data_shared_examples.rb
+1
-0
No files found.
.rubocop_todo.yml
View file @
9cb4a728
...
...
@@ -208,17 +208,6 @@ Naming/RescuedExceptionsVariableName:
RSpec/ContextWording
:
Enabled
:
false
RSpec/EmptyLineAfterSharedExample
:
Exclude
:
-
'
ee/spec/mailers/notify_spec.rb'
-
'
ee/spec/services/quick_actions/interpret_service_spec.rb'
-
'
spec/controllers/repositories/git_http_controller_spec.rb'
-
'
spec/finders/projects/serverless/functions_finder_spec.rb'
-
'
spec/lib/gitlab/hook_data/issuable_builder_spec.rb'
-
'
spec/lib/gitlab/legacy_github_import/importer_spec.rb'
-
'
spec/models/event_spec.rb'
-
'
spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb'
# Offense count: 879
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
...
...
ee/spec/mailers/notify_spec.rb
View file @
9cb4a728
...
...
@@ -173,6 +173,7 @@ describe Notify do
it_behaves_like
'an answer to an existing thread with reply-by-email enabled'
do
let
(
:model
)
{
merge_request
}
end
it_behaves_like
'it should show Gmail Actions View Merge request link'
it_behaves_like
'an unsubscribeable thread'
...
...
@@ -236,6 +237,7 @@ describe Notify do
it_behaves_like
'an answer to an existing thread with reply-by-email enabled'
do
let
(
:model
)
{
merge_request
}
end
it_behaves_like
'it should show Gmail Actions View Merge request link'
it_behaves_like
'an unsubscribeable thread'
...
...
@@ -305,6 +307,7 @@ describe Notify do
it_behaves_like
'an epic email starting a new thread with reply-by-email enabled'
do
let
(
:model
)
{
epic
}
end
it_behaves_like
'it should show Gmail Actions View Epic link'
it_behaves_like
'an unsubscribeable thread'
it_behaves_like
'having group identification headers'
...
...
@@ -362,6 +365,7 @@ describe Notify do
it_behaves_like
'an answer to an existing thread with reply-by-email enabled'
do
let
(
:model
)
{
review
.
merge_request
}
end
it_behaves_like
'it should show Gmail Actions View Merge request link'
it_behaves_like
'an unsubscribeable thread'
...
...
ee/spec/services/quick_actions/interpret_service_spec.rb
View file @
9cb4a728
...
...
@@ -524,6 +524,7 @@ describe QuickActions::InterpretService do
it_behaves_like
'epic relation is removed'
do
let
(
:target
)
{
epic
}
end
it_behaves_like
'quick action is available'
,
:remove_child_epic
do
let
(
:target
)
{
epic
}
end
...
...
@@ -537,6 +538,7 @@ describe QuickActions::InterpretService do
it_behaves_like
'epic relation is removed'
do
let
(
:target
)
{
epic
}
end
it_behaves_like
'quick action is available'
,
:remove_child_epic
do
let
(
:target
)
{
epic
}
end
...
...
spec/controllers/repositories/git_http_controller_spec.rb
View file @
9cb4a728
...
...
@@ -169,6 +169,7 @@ describe Repositories::GitHttpController do
it_behaves_like
'info_refs behavior'
do
let
(
:user
)
{
project
.
owner
}
end
it_behaves_like
'git_upload_pack behavior'
,
true
it_behaves_like
'access checker class'
do
let
(
:expected_class
)
{
Gitlab
::
GitAccess
}
...
...
@@ -183,6 +184,7 @@ describe Repositories::GitHttpController do
it_behaves_like
'info_refs behavior'
do
let
(
:user
)
{
personal_snippet
.
author
}
end
it_behaves_like
'git_upload_pack behavior'
,
false
it_behaves_like
'access checker class'
do
let
(
:expected_class
)
{
Gitlab
::
GitAccessSnippet
}
...
...
@@ -197,6 +199,7 @@ describe Repositories::GitHttpController do
it_behaves_like
'info_refs behavior'
do
let
(
:user
)
{
project_snippet
.
author
}
end
it_behaves_like
'git_upload_pack behavior'
,
false
it_behaves_like
'access checker class'
do
let
(
:expected_class
)
{
Gitlab
::
GitAccessSnippet
}
...
...
spec/finders/projects/serverless/functions_finder_spec.rb
View file @
9cb4a728
...
...
@@ -48,6 +48,7 @@ describe Projects::Serverless::FunctionsFinder do
expect
(
function_finder
.
knative_installed
).
to
be
false
end
end
context
'when project level cluster is present and enabled'
do
it_behaves_like
'before first deployment'
do
let
(
:cluster
)
{
create
(
:cluster
,
:project
,
:provided_by_gcp
,
enabled:
true
)
}
...
...
spec/lib/gitlab/hook_data/issuable_builder_spec.rb
View file @
9cb4a728
...
...
@@ -12,6 +12,7 @@ describe Gitlab::HookData::IssuableBuilder do
include_examples
'project hook data'
do
let
(
:project
)
{
builder
.
issuable
.
project
}
end
include_examples
'deprecated repository hook data'
context
"with a
#{
kind
}
"
do
...
...
spec/lib/gitlab/legacy_github_import/importer_spec.rb
View file @
9cb4a728
...
...
@@ -294,6 +294,7 @@ describe Gitlab::LegacyGithubImport::Importer do
it_behaves_like
'Gitlab::LegacyGithubImport::Importer#execute'
do
let
(
:expected_not_called
)
{
[
:import_releases
,
[
:import_comments
,
:pull_requests
]]
}
end
it_behaves_like
'Gitlab::LegacyGithubImport::Importer#execute an error occurs'
it_behaves_like
'Gitlab::LegacyGithubImport unit-testing'
...
...
spec/models/event_spec.rb
View file @
9cb4a728
...
...
@@ -300,6 +300,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_all
}
end
include_examples
'visible to assignee and author'
,
true
end
...
...
@@ -309,6 +310,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_none_except
(
:member
,
:admin
)
}
end
include_examples
'visible to assignee and author'
,
true
end
end
...
...
@@ -320,6 +322,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_all
}
end
include_examples
'visible to assignee and author'
,
true
end
...
...
@@ -329,6 +332,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_none_except
(
:member
,
:admin
)
}
end
include_examples
'visible to assignee and author'
,
true
end
...
...
@@ -429,6 +433,7 @@ describe Event do
end
# Normally, we'd expect the author of a comment to be able to view it.
# However, this doesn't seem to be the case for comments on snippets.
include_examples
'visible to author'
,
false
end
...
...
@@ -440,6 +445,7 @@ describe Event do
end
# Normally, we'd expect the author of a comment to be able to view it.
# However, this doesn't seem to be the case for comments on snippets.
include_examples
'visible to author'
,
false
end
end
...
...
@@ -450,6 +456,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_all
}
end
include_examples
'visible to author'
,
true
context
'on internal snippet'
do
...
...
@@ -466,6 +473,7 @@ describe Event do
include_examples
'visibility examples'
do
let
(
:visibility
)
{
visible_to_none_except
(
:admin
)
}
end
include_examples
'visible to author'
,
true
end
end
...
...
spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb
View file @
9cb4a728
...
...
@@ -7,6 +7,7 @@ RSpec.shared_examples 'issuable hook data' do |kind|
include_examples
'project hook data'
do
let
(
:project
)
{
builder
.
issuable
.
project
}
end
include_examples
'deprecated repository hook data'
context
"with a
#{
kind
}
"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment