Commit 9d16482f authored by Rémy Coutable's avatar Rémy Coutable

Merge branch 'fe-remove-gitlab-ui-wg-specific-danger' into 'master'

Remove gitlab_ui_wg specific Dangerfile

See merge request gitlab-org/gitlab!31248
parents bc567629 1ca053c1
FRONTEND_MAINTAINERS = %w[filipa iamphill psimyn sarahghp mishunov].freeze
UX_MAINTAINERS = %w[tauriedavis rverissimo].freeze
NO_REVIEWER = 'No reviewer available'.freeze
def mention_single_codebase_approvers
canonical_branch_name =
roulette.canonical_branch_name(gitlab.mr_json['source_branch'])
random = roulette.new_random(canonical_branch_name)
frontend_maintainers = helper.new_teammates(FRONTEND_MAINTAINERS)
ux_maintainers = helper.new_teammates(UX_MAINTAINERS)
rows = []
if gitlab.mr_labels.include?('frontend')
frontend_maintainer =
roulette.spin_for_person(frontend_maintainers, random: random)
rows << "| ~frontend | #{frontend_maintainer&.markdown_name || NO_REVIEWER}"
end
if gitlab.mr_labels.include?('UX')
ux_maintainers =
roulette.spin_for_person(ux_maintainers, random: random)
rows << "| ~UX | #{ux_maintainers&.markdown_name || NO_REVIEWER}"
end
if rows.empty?
backup_maintainer = frontend_maintainers.sample
rows << "| ~frontend / ~UX | #{backup_maintainer.markdown_name}"
end
markdown(<<~MARKDOWN.strip)
## GitLab UI Working Group changes
This merge request contains changes related to the work of [cleaning up CSS and creating
reusable components](https://gitlab.com/groups/gitlab-org/-/epics/950).
These changes will need to be reviewed and approved by the following engineers:
| Category | Reviewer
|----------|---------
#{rows.join("\n")}
To make sure this happens, please follow these steps:
1. Add all of the mentioned users to the list of merge request approvals.
2. Assign the merge request to the first person in the above list.
If you are a reviewer, please follow these steps:
1. Review the merge request. If it is good to go, approve it.
2. Once approved, assign to the next person in the above list. If you are
the last person in the list, merge the merge request.
MARKDOWN
end
if gitlab.mr_labels.include?('CSS cleanup')
mention_single_codebase_approvers
end
...@@ -77,9 +77,7 @@ categories = changes.keys - [:unknown] ...@@ -77,9 +77,7 @@ categories = changes.keys - [:unknown]
# Ensure to spin for database reviewer/maintainer when ~database is applied (e.g. to review SQL queries) # Ensure to spin for database reviewer/maintainer when ~database is applied (e.g. to review SQL queries)
categories << :database if gitlab.mr_labels.include?('database') && !categories.include?(:database) categories << :database if gitlab.mr_labels.include?('database') && !categories.include?(:database)
# CSS Clean up MRs are reviewed using a slightly different process, so we if changes.any?
# disable the review roulette for such MRs.
if changes.any? && !gitlab.mr_labels.include?('CSS cleanup')
# Strip leading and trailing CE/EE markers # Strip leading and trailing CE/EE markers
canonical_branch_name = canonical_branch_name =
roulette.canonical_branch_name(gitlab.mr_json['source_branch']) roulette.canonical_branch_name(gitlab.mr_json['source_branch'])
......
...@@ -20,7 +20,6 @@ class GitlabDanger ...@@ -20,7 +20,6 @@ class GitlabDanger
changelog changelog
specs specs
roulette roulette
gitlab_ui_wg
ce_ee_vue_templates ce_ee_vue_templates
].freeze ].freeze
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment