Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
9dd7f161
Commit
9dd7f161
authored
Oct 05, 2017
by
Luke "Jared" Bennett
Committed by
Phil Hughes
Oct 05, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Navigating to another group board breaks navigation sidebar"
parent
1c14ced6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
2 deletions
+16
-2
app/views/layouts/nav/sidebar/_group.html.haml
app/views/layouts/nav/sidebar/_group.html.haml
+2
-2
spec/features/boards/multiple_boards_spec.rb
spec/features/boards/multiple_boards_spec.rb
+14
-0
No files found.
app/views/layouts/nav/sidebar/_group.html.haml
View file @
9dd7f161
...
@@ -3,7 +3,7 @@
...
@@ -3,7 +3,7 @@
-
issues_sub_menu_items
=
[
'groups#issues'
,
'labels#index'
,
'milestones#index'
]
-
issues_sub_menu_items
=
[
'groups#issues'
,
'labels#index'
,
'milestones#index'
]
-
if
@group
.
feature_available?
(
:group_issue_boards
)
-
if
@group
.
feature_available?
(
:group_issue_boards
)
-
issues_sub_menu_items
.
push
(
'boards#index'
)
-
issues_sub_menu_items
.
push
(
'boards#index'
,
'boards#show'
)
.nav-sidebar
{
class:
(
"sidebar-icons-only"
if
collapsed_sidebar?
)
}
.nav-sidebar
{
class:
(
"sidebar-icons-only"
if
collapsed_sidebar?
)
}
.nav-sidebar-inner-scroll
.nav-sidebar-inner-scroll
...
@@ -64,7 +64,7 @@
...
@@ -64,7 +64,7 @@
List
List
-
if
@group
.
feature_available?
(
:group_issue_boards
)
-
if
@group
.
feature_available?
(
:group_issue_boards
)
=
nav_link
(
path:
'boards#index'
)
do
=
nav_link
(
path:
[
'boards#index'
,
'boards#show'
]
)
do
=
link_to
group_boards_path
(
@group
),
title:
'Boards'
do
=
link_to
group_boards_path
(
@group
),
title:
'Boards'
do
%span
%span
Boards
Boards
...
...
spec/features/boards/multiple_boards_spec.rb
View file @
9dd7f161
...
@@ -143,6 +143,16 @@ describe 'Multiple Issue Boards', :js do
...
@@ -143,6 +143,16 @@ describe 'Multiple Issue Boards', :js do
expect
(
page
).
to
have_selector
(
'.board'
,
count:
2
)
expect
(
page
).
to
have_selector
(
'.board'
,
count:
2
)
end
end
it
'maintains sidebar state over board switch'
do
assert_boards_nav_active
find
(
'.boards-switcher'
).
click
wait_for_requests
click_link
board2
.
name
assert_boards_nav_active
end
end
end
context
'unauthorized user'
do
context
'unauthorized user'
do
...
@@ -195,4 +205,8 @@ describe 'Multiple Issue Boards', :js do
...
@@ -195,4 +205,8 @@ describe 'Multiple Issue Boards', :js do
expect
(
page
).
to
have_content
(
'Some of your boards are hidden, activate a license to see them again.'
)
expect
(
page
).
to
have_content
(
'Some of your boards are hidden, activate a license to see them again.'
)
end
end
end
end
def
assert_boards_nav_active
expect
(
find
(
'.nav-sidebar .active .active'
)).
to
have_selector
(
'a'
,
text:
'Boards'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment