Commit 9edd98f0 authored by Scott Hampton's avatar Scott Hampton

Remove the group_coverage_data_report flag

Remove the feature flag `:group_coverage_data_report`.
parent 7145daf0
...@@ -14906,8 +14906,7 @@ type Project { ...@@ -14906,8 +14906,7 @@ type Project {
): ClusterAgentConnection ): ClusterAgentConnection
""" """
Code coverages summary associated with the project. Available only when Code coverages summary associated with the project
feature flag `group_coverage_data_report` is enabled
""" """
codeCoverageSummary: CodeCoverageSummary codeCoverageSummary: CodeCoverageSummary
......
...@@ -43989,7 +43989,7 @@ ...@@ -43989,7 +43989,7 @@
}, },
{ {
"name": "codeCoverageSummary", "name": "codeCoverageSummary",
"description": "Code coverages summary associated with the project. Available only when feature flag `group_coverage_data_report` is enabled", "description": "Code coverages summary associated with the project",
"args": [ "args": [
], ],
...@@ -2248,7 +2248,7 @@ Autogenerated return type of PipelineRetry. ...@@ -2248,7 +2248,7 @@ Autogenerated return type of PipelineRetry.
| `boards` | BoardConnection | Boards of the project | | `boards` | BoardConnection | Boards of the project |
| `clusterAgent` | ClusterAgent | Find a single cluster agent by name | | `clusterAgent` | ClusterAgent | Find a single cluster agent by name |
| `clusterAgents` | ClusterAgentConnection | Cluster agents associated with the project | | `clusterAgents` | ClusterAgentConnection | Cluster agents associated with the project |
| `codeCoverageSummary` | CodeCoverageSummary | Code coverages summary associated with the project. Available only when feature flag `group_coverage_data_report` is enabled | | `codeCoverageSummary` | CodeCoverageSummary | Code coverages summary associated with the project |
| `complianceFrameworks` | ComplianceFrameworkConnection | Compliance frameworks associated with the project | | `complianceFrameworks` | ComplianceFrameworkConnection | Compliance frameworks associated with the project |
| `containerExpirationPolicy` | ContainerExpirationPolicy | The container expiration policy of the project | | `containerExpirationPolicy` | ContainerExpirationPolicy | The container expiration policy of the project |
| `containerRegistryEnabled` | Boolean | Indicates if the project stores Docker container images in a container registry | | `containerRegistryEnabled` | Boolean | Indicates if the project stores Docker container images in a container registry |
......
...@@ -15,22 +15,12 @@ This feature might not be available to you. Check the **version history** note a ...@@ -15,22 +15,12 @@ This feature might not be available to you. Check the **version history** note a
## Latest project test coverage list ## Latest project test coverage list
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/267624) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.6. > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/267624) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.6.
> - It's [deployed behind a feature flag](../../../user/feature_flags.md), disabled by default.
> - It's disabled on GitLab.com
> - It can be enabled or disabled per-group.
> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enable-or-disable-latest-project-test-coverage).
To see the latest code coverage for each project in your group: To see the latest code coverage for each project in your group:
1. Go to **Analytics > Repositories** in the group (not from a project). 1. Go to **Analytics > Repositories** in the group (not from a project).
1. In the **Latest test coverage results** section, use the **Select projects** dropdown to choose the projects you want to check. 1. In the **Latest test coverage results** section, use the **Select projects** dropdown to choose the projects you want to check.
### Enable or disable latest project test coverage
This feature comes with the `:group_coverage_data_report` feature flag disabled by default. It is disabled on GitLab.com.
[GitLab administrators with access to the GitLab Rails console](../../../administration/feature_flags.md) can enable it for your instance.
The group test coverage table can be enabled or disabled per-group.
## Download historic test coverage data ## Download historic test coverage data
> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/215104) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.4. > [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/215104) in [GitLab Premium](https://about.gitlab.com/pricing/) 13.4.
......
...@@ -20,9 +20,6 @@ export default { ...@@ -20,9 +20,6 @@ export default {
shouldShowCoverageSummary() { shouldShowCoverageSummary() {
return this.glFeatures.groupCoverageDataReportGraph; return this.glFeatures.groupCoverageDataReportGraph;
}, },
shouldShowCoverageReport() {
return this.glFeatures.groupCoverageDataReport;
},
}, },
}; };
</script> </script>
...@@ -33,7 +30,7 @@ export default { ...@@ -33,7 +30,7 @@ export default {
{{ $options.text.codeCoverageHeader }} {{ $options.text.codeCoverageHeader }}
</h4> </h4>
<test-coverage-summary v-if="shouldShowCoverageSummary" /> <test-coverage-summary v-if="shouldShowCoverageSummary" />
<test-coverage-table v-if="shouldShowCoverageReport" class="gl-mb-5" /> <test-coverage-table class="gl-mb-5" />
<download-test-coverage /> <download-test-coverage />
</div> </div>
</template> </template>
...@@ -6,7 +6,6 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl ...@@ -6,7 +6,6 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl
before_action :load_group before_action :load_group
before_action -> { check_feature_availability!(:group_repository_analytics) } before_action -> { check_feature_availability!(:group_repository_analytics) }
before_action -> { authorize_view_by_action!(:read_group_repository_analytics) } before_action -> { authorize_view_by_action!(:read_group_repository_analytics) }
before_action -> { push_frontend_feature_flag(:group_coverage_data_report, @group, default_enabled: false) }
before_action -> { push_frontend_feature_flag(:group_coverage_data_report_graph, @group, default_enabled: false) } before_action -> { push_frontend_feature_flag(:group_coverage_data_report_graph, @group, default_enabled: false) }
def show def show
......
...@@ -146,8 +146,7 @@ module EE ...@@ -146,8 +146,7 @@ module EE
::Types::Ci::CodeCoverageSummaryType, ::Types::Ci::CodeCoverageSummaryType,
null: true, null: true,
description: 'Code coverages summary associated with the project', description: 'Code coverages summary associated with the project',
resolver: ::Resolvers::Ci::CodeCoverageSummaryResolver, resolver: ::Resolvers::Ci::CodeCoverageSummaryResolver
feature_flag: :group_coverage_data_report
def self.sast_ci_configuration(project) def self.sast_ci_configuration(project)
::Security::CiConfiguration::SastParserService.new(project).configuration ::Security::CiConfiguration::SastParserService.new(project).configuration
......
---
title: Add latest project test coverage list to group repositories analytics
merge_request: 47572
author:
type: added
---
name: group_coverage_data_report
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/43774
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/215135/
milestone: '13.5'
type: development
group: group::testing
default_enabled: false
...@@ -67,13 +67,4 @@ RSpec.describe 'Getting code coverage summary in a project' do ...@@ -67,13 +67,4 @@ RSpec.describe 'Getting code coverage summary in a project' do
expect(code_coverage_summary_graphql_data).to be_nil expect(code_coverage_summary_graphql_data).to be_nil
end end
end end
context 'when group_coverage_data_report flag is disabled' do
it 'returns a graphQL error field does not exist' do
stub_feature_flags(group_coverage_data_report: false)
post_graphql(query, current_user: current_user)
expect_graphql_errors_to_include(/Field 'codeCoverageSummary' doesn't exist on type 'Project'/)
end
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment