Clean up non TODO rubocop errors

app/controllers/projects/settings/repository_controller.rb

@@ -13,7 +13,7 @@ module Projects
 
       def define_protected_refs
         @protected_branches = @project.protected_branches.order(:name).page(params[:page])
-        @protected_tags = @project.protected_tags.order(:name).page(params[:page])
+        @protected_tags = @project.protected_tags.order(:name).page(params[:page]) #TODO duplicated pagination param?
         @protected_branch = @project.protected_branches.new
         @protected_tag = @project.protected_tags.new
         load_gon_index

app/models/concerns/protected_ref.rb

@@ -18,8 +18,6 @@ module ProtectedRef
       self.matching(ref).map(&:"@#{action}_access_levels").flatten
     end
 
-    private
-
     def self.matching(ref_name, protected_refs: nil)
       ProtectedRefMatcher.matching(self, ref_name, protected_refs: protected_refs)
     end

app/models/concerns/protected_ref_access.rb

+#TODO: Refactor, checking EE
 # module ProtectedRefAccess
 #   extend ActiveSupport::Concern
 

lib/gitlab/checks/change_access.rb

@@ -71,15 +71,15 @@ module Gitlab
       def protected_tag_checks
         return unless tag_protected?
 
-        if forced_push?
-          return "You are not allowed to force push protected tags." #TODO: Wording, 'not allowed to update proteted tags'?
+        if forced_push? #TODO: Verify if this should prevent all updates, and mention in UI and documentation
+          return "Protected tags cannot be updated."
         end
 
         if Gitlab::Git.blank_ref?(@newrev)
-          return "You are not allowed to delete protected tags." #TODO: Wording, do these need to mention 'you' if the rule applies to everyone
+          return "Protected tags cannot be deleted."
         end
 
-        if !user_access.can_push_tag?(@tag_name)
+        unless user_access.can_push_tag?(@tag_name)
           return "You are not allowed to create this tag as it is protected."
         end
       end

lib/gitlab/import_export/relation_factory.rb

@@ -7,7 +7,7 @@ module Gitlab
                     triggers: 'Ci::Trigger',
                     builds: 'Ci::Build',
                     hooks: 'ProjectHook',
-                    merge_access_levels: 'ProtectedBranch::MergeAccessLevel',
+                    merge_access_levels: 'ProtectedBranch::MergeAccessLevel', #TODO: Tags
                     push_access_levels: 'ProtectedBranch::PushAccessLevel',
                     labels: :project_labels,
                     priorities: :label_priorities,

spec/controllers/projects/protected_tags_controller_spec.rb

 require('spec_helper')
 
 describe Projects::ProtectedTagsController do
-  # describe "GET #index" do
-  #   let(:project) { create(:project_empty_repo, :public) }
-  #   it "redirects empty repo to projects page" do
-  #     get(:index, namespace_id: project.namespace.to_param, project_id: project)
-  #   end
-  # end
+  describe "GET #index" do
+    let(:project) { create(:project_empty_repo, :public) }
+    it "redirects empty repo to projects page" do
+      get(:index, namespace_id: project.namespace.to_param, project_id: project)
+    end
+  end
 end