Avoid assignment in if

a0162388 · Lin Jen-Shin · fcc6a592 · a0162388
Commit a0162388 authored Jun 15, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

lib/gitlab/email/receiver.rb lib/gitlab/email/receiver.rb +2 -1

No files found.
--- a/lib/gitlab/email/receiver.rb
+++ b/lib/gitlab/email/receiver.rb
@@ -28,8 +28,9 @@ module Gitlab

        mail = build_mail
        mail_key = extract_mail_key(mail)
+        handler = Handler.for(mail, mail_key)

-        if handler = Handler.for(mail, mail_key)
+        if handler
          handler.execute
        else
          raise UnknownIncomingEmail