Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a02ad24f
Commit
a02ad24f
authored
Apr 27, 2021
by
Sean McGivern
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add details on new Sidekiq workers and canary deploys
parent
a3c6d078
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
17 additions
and
0 deletions
+17
-0
doc/development/sidekiq_style_guide.md
doc/development/sidekiq_style_guide.md
+17
-0
No files found.
doc/development/sidekiq_style_guide.md
View file @
a02ad24f
...
@@ -719,6 +719,23 @@ possible situations:
...
@@ -719,6 +719,23 @@ possible situations:
1.
A job is queued by a node running the newer version of the application, but
1.
A job is queued by a node running the newer version of the application, but
executed on a node running an older version of the application.
executed on a node running an older version of the application.
### Adding new workers
On GitLab.com, we
[
do not currently have a Sidekiq deployment in the
canary stage
](
https://gitlab.com/gitlab-org/gitlab/-/issues/19239
)
. This
means that a new worker than can be scheduled from an HTTP endpoint may
be scheduled from canary but not run on Sidekiq until the full
production deployment is complete. This can be several hours later than
scheduling the job. For some workers, this will not be a problem. For
others - particularly
[
latency-sensitive
jobs
](
#latency-sensitive-jobs
)
- this will result in a poor user
experience.
This only applies to new worker classes when they are first introduced.
As we recommend
[
using feature flags
](
feature_flags/
)
as a general
development process, it's best to control the entire change (including
scheduling of the new Sidekiq worker) with a feature flag.
### Changing the arguments for a worker
### Changing the arguments for a worker
Jobs need to be backward and forward compatible between consecutive versions
Jobs need to be backward and forward compatible between consecutive versions
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment