Merge branch 'do-not-perform-disk-check-ee' into 'master'

Do not perform hard check (presence of file on storage)

Closes gitlab-ce#37945

See merge request gitlab-org/gitlab-ee!2960

app/controllers/projects/uploads_controller.rb

@@ -28,7 +28,7 @@ class Projects::UploadsController < Projects::ApplicationController
   end
 
   def image_or_video?
-    uploader && uploader.file.exists? && uploader.image_or_video?
+    uploader && uploader.exists? && uploader.image_or_video?
   end
 
   def uploader_class

app/uploaders/avatar_uploader.rb

@@ -9,7 +9,7 @@ class AvatarUploader < GitlabUploader
   end
 
   def exists?
-    model.avatar.file && model.avatar.file.exists?
+    model.avatar.file && model.avatar.file.present?
   end
 
   # We set move_to_store and move_to_cache to 'false' to prevent stealing

app/uploaders/gitlab_uploader.rb

@@ -51,7 +51,7 @@ class GitlabUploader < CarrierWave::Uploader::Base
   end
 
   def exists?
-    file.try(:exists?)
+    file.present?
   end
 
   # Override this if you don't want to save files by default to the Rails.root directory

app/uploaders/object_store_uploader.rb

@@ -161,7 +161,7 @@ class ObjectStoreUploader < CarrierWave::Uploader::Base
   end
 
   def exists?
-    file.try(:exists?)
+    file.present?
   end
 
   def cache_dir

changelogs/unreleased-ee/do-not-perform-disk-check.yml

+---
+title: File uploaders do not perform hard check, only soft check
+merge_request:
+author:
+type: fixed