Merge branch 'refactoring_of_old_commit' into 'master'

Performance improvement of push rules

We don't need to check temp ref anymore since  https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/563 is merged

related https://gitlab.com/gitlab-org/gitlab-ce/issues/14280#note_13198239

See merge request !578

CHANGELOG-EE

@@ -10,6 +10,7 @@ v 8.10.0 (unreleased)
   - Fix of removing wiki data from index when project is deleted
   - Ticket-based Kerberos authentication (SPNEGO)
   - [Elastic] Suppress ActiveRecord::RecordNotFound error in ElasticIndexWorker
+  - Performance improvement of push rules
 
 v.8.9.7 (unreleased)
   - Fix error in admin dashboard when Geo is enabled and current node is nil.

lib/gitlab/git_access.rb

@@ -297,8 +297,7 @@ module Gitlab
     end
 
     def old_commit?(commit)
-      # We skip refs/tmp ref because we use it for Web UI commiting
-      commit.refs(project.repository).reject { |ref| ref.name.start_with?('refs/tmp') }.any?
+      commit.refs(project.repository).any?
     end
   end
 end