Merge branch '332402-remove-web-performance-widget-usage-data-feature-flag' into 'master'

Remove web performance widget usage data flag

See merge request gitlab-org/gitlab!68837

config/feature_flags/development/usage_data_i_testing_web_performance_widget_total.yml

----
-name: usage_data_i_testing_web_performance_widget_total
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/46746
-rollout_issue_url:
-milestone: '13.8'
-type: development
-group: group::testing
-default_enabled: true

ee/app/assets/javascripts/reports/browser_performance_report/grouped_browser_performance_reports_app.vue

@@ -3,14 +3,12 @@ import { once } from 'lodash';
 import { componentNames } from 'ee/reports/components/issue_body';
 import api from '~/api';
 import ReportSection from '~/reports/components/report_section.vue';
-import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
 
 export default {
   name: 'GroupedBrowserPerformanceReportsApp',
   components: {
     ReportSection,
   },
-  mixins: [glFeatureFlagsMixin()],
   props: {
     status: {
       type: String,
@@ -49,9 +47,7 @@ export default {
   computed: {
     handleBrowserPerformanceToggleEvent() {
       return once(() => {
-        if (this.glFeatures.usageDataITestingWebPerformanceWidgetTotal) {
-          api.trackRedisHllUserEvent(this.$options.expandEvent);
-        }
+        api.trackRedisHllUserEvent(this.$options.expandEvent);
       });
     },
   },

ee/app/controllers/ee/projects/merge_requests_controller.rb

@@ -12,7 +12,6 @@ module EE
           push_frontend_feature_flag(:anonymous_visual_review_feedback)
           push_frontend_feature_flag(:missing_mr_security_scan_types, @project)
           push_frontend_feature_flag(:usage_data_i_testing_metrics_report_widget_total, @project, default_enabled: true)
-          push_frontend_feature_flag(:usage_data_i_testing_web_performance_widget_total, @project, default_enabled: true)
           push_frontend_feature_flag(:usage_data_i_testing_load_performance_widget_total, @project, default_enabled: true)
         end
 

ee/spec/frontend/reports/browser_performance_report/grouped_browser_performance_reports_app_spec.js

@@ -9,7 +9,7 @@ const localVue = createLocalVue();
 describe('Grouped test reports app', () => {
   let wrapper;
 
-  const mountComponent = ({ usageDataITestingWebPerformanceWidgetTotal = false } = {}) => {
+  const mountComponent = () => {
     wrapper = mount(GroupedBrowserPerformanceReportsApp, {
       localVue,
       propsData: {
@@ -22,42 +22,23 @@ describe('Grouped test reports app', () => {
         neutralIssues: [],
         hasIssues: true,
       },
-      provide: {
-        glFeatures: {
-          usageDataITestingWebPerformanceWidgetTotal,
-        },
-      },
     });
   };
 
+  beforeEach(() => {
+    mountComponent();
+  });
+
   afterEach(() => {
     wrapper.destroy();
     wrapper = null;
   });
 
   describe('service ping events', () => {
-    describe('when feature flag is enabled', () => {
-      beforeEach(() => {
-        mountComponent({ usageDataITestingWebPerformanceWidgetTotal: true });
-      });
-
-      it('tracks an event when the widget is expanded', () => {
-        wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
-
-        expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
-      });
-    });
-
-    describe('when feature flag is disabled', () => {
-      beforeEach(() => {
-        mountComponent({ usageDataITestingWebPerformanceWidgetTotal: false });
-      });
-
-      it('tracks an event when the widget is expanded', () => {
-        wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
+    it('tracks an event when the widget is expanded', () => {
+      wrapper.find('[data-testid="report-section-expand-button"]').trigger('click');
 
-        expect(Api.trackRedisHllUserEvent).not.toHaveBeenCalled();
-      });
+      expect(Api.trackRedisHllUserEvent).toHaveBeenCalledWith(wrapper.vm.$options.expandEvent);
     });
   });
 });

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -168,7 +168,6 @@
   category: testing
   redis_slot: testing
   aggregation: weekly
-  feature_flag: usage_data_i_testing_web_performance_widget_total
 - name: i_testing_group_code_coverage_project_click_total
   category: testing
   redis_slot: testing