Commit a22646af authored by Rémy Coutable's avatar Rémy Coutable

Ensure 'build-qa-image' is created for all pipelines except docs & qa

This also makes 'package-and-qa-manual' created for 'master' because
it's a valid use-case to run manual QA on 'master'.

Without this change, no pipeline could be created for auto-deploy
branches due to the following error:

    The form contains the following error:
    package-and-qa-manual: needs 'build-qa-image'
Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent abd9e842
...@@ -21,10 +21,6 @@ package-and-qa-manual: ...@@ -21,10 +21,6 @@ package-and-qa-manual:
- .package-and-qa-base - .package-and-qa-base
- .except-docs-qa - .except-docs-qa
when: manual when: manual
except:
- master
- /(^docs[\/-].+|.+-docs$)/
- /(^qa[\/-].*|.*-qa$)
package-and-qa: package-and-qa:
extends: .package-and-qa-base extends: .package-and-qa-base
......
...@@ -22,7 +22,9 @@ ...@@ -22,7 +22,9 @@
- source scripts/utils.sh - source scripts/utils.sh
.review-docker: .review-docker:
extends: .review-base extends:
- .default-tags
- .default-retry
image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-alpine image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-alpine
services: services:
- docker:19.03.0-dind - docker:19.03.0-dind
...@@ -36,7 +38,13 @@ ...@@ -36,7 +38,13 @@
QA_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab/${CI_PROJECT_NAME}-qa:${CI_COMMIT_REF_SLUG}" QA_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab/${CI_PROJECT_NAME}-qa:${CI_COMMIT_REF_SLUG}"
build-qa-image: build-qa-image:
extends: .review-docker extends:
- .review-docker
- .except-docs-qa
only:
refs:
- branches@gitlab-org/gitlab-ce
- branches@gitlab-org/gitlab-ee
stage: test stage: test
script: script:
- time docker build --cache-from ${LATEST_QA_IMAGE} --tag ${QA_IMAGE} --file ./qa/Dockerfile ./ - time docker build --cache-from ${LATEST_QA_IMAGE} --tag ${QA_IMAGE} --file ./qa/Dockerfile ./
...@@ -124,7 +132,9 @@ review-stop: ...@@ -124,7 +132,9 @@ review-stop:
artifacts: {} artifacts: {}
.review-qa-base: .review-qa-base:
extends: .review-docker extends:
- .review-docker
- .review-only
retry: 2 retry: 2
stage: qa stage: qa
variables: variables:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment