Rework loading state

* Rework hasLoading to use isLoading
* Remove unused mutations due to set endpoint action being removed
* Remove hasLoading mutations

ee/app/assets/javascripts/approvals/components/rule_form.vue

@@ -52,12 +52,12 @@ export default {
       containsHiddenGroups: false,
       ...this.getInitialData(),
     };
-    // TODO: Remove feature flag in https://gitlab.com/gitlab-org/gitlab/-/issues/235114  
-    if(this.glFeatures.approvalSuggestions){
-      return { ...defaults, name: this.defaultRuleName || ''};
+    // TODO: Remove feature flag in https://gitlab.com/gitlab-org/gitlab/-/issues/235114
+    if (this.glFeatures.approvalSuggestions) {
+      return { ...defaults, name: this.defaultRuleName || '' };
     }
 
-    return defaults
+    return defaults;
   },
   computed: {
     ...mapState(['settings']),

ee/app/assets/javascripts/approvals/components/security_configuration/unconfigured_security_rules.vue

@@ -23,11 +23,11 @@ export default {
     ...mapState('securityConfiguration', ['configuration']),
     ...mapState({
       rules: state => state.approvals.rules,
-      hasApprovalsLoaded: state => state.approvals.hasLoaded,
-      hasSecurityConfigurationLoaded: state => state.securityConfiguration.hasLoaded,
+      isApprovalsLoading: state => state.approvals.isLoading,
+      isSecurityConfigurationLoading: state => state.securityConfiguration.isLoading,
     }),
     isRulesLoading() {
-      return !this.hasApprovalsLoaded || !this.hasSecurityConfigurationLoaded;
+      return this.isApprovalsLoading || this.isSecurityConfigurationLoading;
     },
     securityRules() {
       return [
@@ -56,7 +56,7 @@ export default {
   },
   created() {
     this.fetchSecurityConfiguration();
-  },  
+  },
   methods: {
     ...mapActions('securityConfiguration', ['fetchSecurityConfiguration']),
     ...mapActions({ openCreateModal: 'createModal/open' }),

ee/app/assets/javascripts/security_configuration/modules/configuration/actions.js

@@ -2,9 +2,7 @@ import axios from '~/lib/utils/axios_utils';
 import * as Sentry from '@sentry/browser';
 import * as types from './mutation_types';
 
-export const setSecurityConfigurationEndpoint = ({ commit }, endpoint) =>
-  commit(types.SET_SECURITY_CONFIGURATION_ENDPOINT, endpoint);
-
+// eslint-disable-next-line import/prefer-default-export
 export const fetchSecurityConfiguration = ({ commit, state }) => {
   if (!state.securityConfigurationPath) {
     return commit(types.RECEIVE_SECURITY_CONFIGURATION_ERROR);

ee/app/assets/javascripts/security_configuration/modules/configuration/mutation_types.js

-export const SET_SECURITY_CONFIGURATION_ENDPOINT = 'SET_SECURITY_CONFIGURATION_ENDPOINT';
-
 export const REQUEST_SECURITY_CONFIGURATION = 'REQUEST_SECURITY_CONFIGURATION';
 export const RECEIVE_SECURITY_CONFIGURATION_SUCCESS = 'RECEIVE_SECURITY_CONFIGURATION_SUCCESS';
 export const RECEIVE_SECURITY_CONFIGURATION_ERROR = 'RECEIVE_SECURITY_CONFIGURATION_ERROR';

ee/app/assets/javascripts/security_configuration/modules/configuration/mutations.js

 import * as types from './mutation_types';
 
 export default {
-  [types.SET_SECURITY_CONFIGURATION_ENDPOINT](state, payload) {
-    state.securityConfigurationPath = payload;
-  },
   [types.REQUEST_SECURITY_CONFIGURATION](state) {
     state.isLoading = true;
     state.errorLoading = false;
   },
   [types.RECEIVE_SECURITY_CONFIGURATION_SUCCESS](state, payload) {
     state.isLoading = false;
-    state.hasLoaded = true;
     state.errorLoading = false;
     state.configuration = payload;
   },

ee/app/assets/javascripts/security_configuration/modules/configuration/state.js

 export default ({ securityConfigurationPath }) => ({
   securityConfigurationPath,
   isLoading: false,
-  hasLoaded: false,
   errorLoading: false,
   configuration: {},
 });