Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a2a534b8
Commit
a2a534b8
authored
Aug 24, 2020
by
Robert Hunt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated the pipeline schedules callout FA icon to use GlIcon close
parent
defb965d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
1 deletion
+10
-1
app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/pipeline_schedules_callout.vue
...chedules/shared/components/pipeline_schedules_callout.vue
+5
-1
changelogs/unreleased/224534-replace-fa-times-with-gitlab-svg-close-icon-for-promotions.yml
...ce-fa-times-with-gitlab-svg-close-icon-for-promotions.yml
+5
-0
No files found.
app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/pipeline_schedules_callout.vue
View file @
a2a534b8
...
...
@@ -2,6 +2,7 @@
/* eslint-disable vue/no-v-html */
import
Vue
from
'
vue
'
;
import
Cookies
from
'
js-cookie
'
;
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
Translate
from
'
../../../../../vue_shared/translate
'
;
// Full path is needed for Jest to be able to correctly mock this file
import
illustrationSvg
from
'
~/pages/projects/pipeline_schedules/shared/icons/intro_illustration.svg
'
;
...
...
@@ -13,6 +14,9 @@ const cookieKey = 'pipeline_schedules_callout_dismissed';
export
default
{
name
:
'
PipelineSchedulesCallout
'
,
components
:
{
GlIcon
,
},
data
()
{
return
{
docsUrl
:
document
.
getElementById
(
'
pipeline-schedules-callout
'
).
dataset
.
docsUrl
,
...
...
@@ -34,7 +38,7 @@ export default {
<div
v-if=
"!calloutDismissed"
class=
"pipeline-schedules-user-callout user-callout"
>
<div
class=
"bordered-box landing content-block"
>
<button
id=
"dismiss-callout-btn"
class=
"btn btn-default close"
@
click=
"dismissCallout"
>
<
i
aria-hidden=
"true"
class=
"fa fa-times"
>
</i
>
<
gl-icon
name=
"close"
aria-hidden=
"true"
/
>
</button>
<div
class=
"svg-container"
v-html=
"illustrationSvg"
></div>
<div
class=
"user-callout-copy"
>
...
...
changelogs/unreleased/224534-replace-fa-times-with-gitlab-svg-close-icon-for-promotions.yml
0 → 100644
View file @
a2a534b8
---
title
:
Replace fa-times with GitLab SVG close icon in promotions
merge_request
:
40586
author
:
type
:
performance
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment