Merge branch 'mf-license-check-for-full-codequality-report' into 'master'

Add license check for full code quality report

See merge request gitlab-org/gitlab!53258

ee/app/models/license.rb

@@ -21,6 +21,7 @@ class License < ApplicationRecord
     contribution_analytics
     description_diffs
     elastic_search
+    full_codequality_report
     group_activity_analytics
     group_bulk_edit
     group_webhooks

ee/app/views/projects/pipelines/_tabs_content.html.haml

@@ -5,7 +5,7 @@
 - licenses_api_path = licenses_project_pipeline_path(project, pipeline) if project.feature_available?(:license_scanning)
 - vulnerabilities_endpoint_path = expose_path(api_v4_projects_vulnerability_findings_path(id: project.id, params: { pipeline_id: pipeline.id }))
 - vulnerability_exports_endpoint_path = expose_path(api_v4_security_projects_vulnerability_exports_path(id: project.id))
-- codequality_report_download_path = pipeline.downloadable_path_for_report_type(:codequality)
+- codequality_report_download_path = pipeline.downloadable_path_for_report_type(:codequality) if project.feature_available?(:full_codequality_report)
 
 - if pipeline.expose_security_dashboard?
   #js-tab-security.build-security.tab-pane

ee/app/views/projects/pipelines/_tabs_holder.html.haml

@@ -12,7 +12,7 @@
       = _("Licenses")
       %span.badge.badge-pill.js-licenses-counter.hidden{ data: { qa_selector: 'licenses_counter' } }
 
-- if pipeline.downloadable_path_for_report_type(:codequality)
+- if project.feature_available?(:full_codequality_report) && pipeline.downloadable_path_for_report_type(:codequality)
   %li.js-codequality-tab-link
     = link_to codequality_report_project_pipeline_path(project, pipeline), data: { target: '#js-tab-codequality', action: 'codequality_report', toggle: 'tab', 'track-event': 'click_button', 'track-label': 'get_codequality_report' }, class: 'codequality-tab' do
       = _('Code Quality')

ee/changelogs/unreleased/mf-license-check-for-full-codequality-report.yml

+---
+title: Add license check for full code quality report
+merge_request: 53258
+author:
+type: fixed

ee/spec/features/projects/pipelines/pipeline_spec.rb

@@ -169,34 +169,53 @@ RSpec.describe 'Pipeline', :js do
 
   describe 'GET /:project/pipelines/:id/codequality_report', :aggregate_failures do
     shared_examples_for 'full codequality report' do
-      context 'with no code quality artifact' do
+      context 'when licensed' do
         before do
-          create(:ee_ci_build, pipeline: pipeline)
-          visit project_pipeline_path(project, pipeline)
+          stub_licensed_features(full_codequality_report: true)
         end
 
-        it 'does not show code quality tab' do
-          expect(page).not_to have_content('Code Quality')
-          expect(page).not_to have_css('#js-tab-codequality')
+        context 'with code quality artifact' do
+          before do
+            create(:ee_ci_build, :codequality, pipeline: pipeline)
+            visit codequality_report_project_pipeline_path(project, pipeline)
+          end
+
+          it 'shows code quality tab pane as active, quality issue with link to file, and events for data tracking' do
+            expect(page).to have_content('Code Quality')
+            expect(page).to have_css('#js-tab-codequality')
+
+            expect(page).to have_content('Method `new_array` has 12 arguments (exceeds 4 allowed). Consider refactoring.')
+            expect(find_link('foo.rb:10')[:href]).to end_with(project_blob_path(project, File.join(pipeline.commit.id, 'foo.rb')) + '#L10')
+
+            expect(page).to have_selector('[data-track-event="click_button"]')
+            expect(page).to have_selector('[data-track-label="get_codequality_report"]')
+          end
+        end
+
+        context 'with no code quality artifact' do
+          before do
+            create(:ee_ci_build, pipeline: pipeline)
+            visit project_pipeline_path(project, pipeline)
+          end
+
+          it 'does not show code quality tab' do
+            expect(page).not_to have_content('Code Quality')
+            expect(page).not_to have_css('#js-tab-codequality')
+          end
         end
       end
 
-      context 'with code quality artifact' do
+      context 'when unlicensed' do
         before do
+          stub_licensed_features(full_codequality_report: false)
+
           create(:ee_ci_build, :codequality, pipeline: pipeline)
-          visit codequality_report_project_pipeline_path(project, pipeline)
-          wait_for_requests
+          visit project_pipeline_path(project, pipeline)
         end
 
-        it 'shows code quality tab pane as active, quality issue with link to file, and events for data tracking' do
-          expect(page).to have_content('Code Quality')
-          expect(page).to have_css('#js-tab-codequality')
-
-          expect(page).to have_content('Method `new_array` has 12 arguments (exceeds 4 allowed). Consider refactoring.')
-          expect(find_link('foo.rb:10')[:href]).to end_with(project_blob_path(project, File.join(pipeline.commit.id, 'foo.rb')) + '#L10')
-
-          expect(page).to have_selector('[data-track-event="click_button"]')
-          expect(page).to have_selector('[data-track-label="get_codequality_report"]')
+        it 'does not show code quality tab' do
+          expect(page).not_to have_content('Code Quality')
+          expect(page).not_to have_css('#js-tab-codequality')
         end
       end
     end