Commit a5586948 authored by Rémy Coutable's avatar Rémy Coutable

Merge branch 'fix-filename-length' into 'master'

Ensure changelog filenames have length less than 99 characters

See merge request gitlab-org/gitlab-ce!31752
parents c9fc8f9f 9ab5346e
......@@ -23,7 +23,7 @@ module ChangelogHelpers
Abort = Class.new(StandardError)
Done = Class.new(StandardError)
MAX_FILENAME_LENGTH = 140 # ecryptfs has a limit of 140 characters
MAX_FILENAME_LENGTH = 99 # GNU tar has a 99 character limit
def capture_stdout(cmd)
output = IO.popen(cmd, &:read)
......
......@@ -15,7 +15,7 @@ describe 'bin/changelog' do
allow(entry).to receive(:branch_name).and_return('long-branch-' * 100)
file_path = entry.send(:file_path)
expect(file_path.length).to eq(140)
expect(file_path.length).to eq(99)
end
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment