Merge branch 'update-new-test-to-use-let-variables' into 'master'

Update new test to use let variables to follow our testing best practices

See merge request gitlab-org/gitlab!17946

qa/qa/specs/features/ee/browser_ui/2_plan/related_issues/related_issues_spec.rb

@@ -4,39 +4,43 @@ module QA
   context 'Plan' do
     describe 'Related issues' do
       let(:project) do
-        Resource::Project.fabricate_via_api! do |resource|
-          resource.name = 'project-to-test-related-issues'
+        Resource::Project.fabricate_via_api! do |project|
+          project.name = 'project-to-test-related-issues'
         end
       end
 
-      before do
-        Runtime::Browser.visit(:gitlab, Page::Main::Login)
-        Page::Main::Login.perform(&:sign_in_using_credentials)
-
-        @issue_1 = Resource::Issue.fabricate_via_api! do |issue|
+      let(:issue_1) do
+        Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
           issue.title = 'Issue 1'
         end
+      end
 
-        @issue_2 = Resource::Issue.fabricate_via_api! do |issue|
+      let(:issue_2) do
+        Resource::Issue.fabricate_via_api! do |issue|
           issue.project = project
           issue.title = 'Issue 2'
         end
       end
 
+      before do
+        Runtime::Browser.visit(:gitlab, Page::Main::Login)
+        Page::Main::Login.perform(&:sign_in_using_credentials)
+      end
+
       it 'relates and unrelates one issue to/from another' do
-        @issue_1.visit!
+        issue_1.visit!
 
         Page::Project::Issue::Show.perform do |show|
-          show.relate_issue(@issue_2)
+          show.relate_issue(issue_2)
 
-          expect(show).to have_content("marked this issue as related to ##{@issue_2.iid}")
-          expect(show.related_issuable_item).to have_content(@issue_2.title)
+          expect(show).to have_content("marked this issue as related to ##{issue_2.iid}")
+          expect(show.related_issuable_item).to have_content(issue_2.title)
 
           show.click_remove_issue_button
 
-          expect(show).to have_content("removed the relation with ##{@issue_2.iid}")
-          expect(show).not_to have_content(@issue_2.title)
+          expect(show).to have_content("removed the relation with ##{issue_2.iid}")
+          expect(show).not_to have_content(issue_2.title)
         end
       end
     end