Merge branch...

Merge branch 'dreedy-use-find-verbiage-instead-of-get-verbiage-for-spec-helper-methods' into 'master'

Use find rather than get verbiage for spec helpers

See merge request gitlab-org/gitlab!59049

ee/spec/frontend/contextual_sidebar/group_trial_status_popover_spec.js

@@ -9,7 +9,7 @@ describe('TrialStatusPopover component', () => {
   let wrapper;
   let trackingSpy;
 
-  const getGlButton = (testId) => wrapper.find(`[data-testid="${testId}"]`);
+  const findByTestId = (testId) => wrapper.find(`[data-testid="${testId}"]`);
 
   const createComponent = () => {
     return shallowMount(TrialStatusPopover, {
@@ -41,14 +41,14 @@ describe('TrialStatusPopover component', () => {
   });
 
   it('renders the upgrade button with correct tracking data attrs', () => {
-    const attrs = getGlButton('upgradeBtn').attributes();
+    const attrs = findByTestId('upgradeBtn').attributes();
     expect(attrs['data-track-event']).toBe('click_button');
     expect(attrs['data-track-label']).toBe('upgrade_to_ultimate');
     expect(attrs['data-track-property']).toBe('experiment:show_trial_status_in_sidebar');
   });
 
   it('renders the compare plans button with correct tracking data attrs', () => {
-    const attrs = getGlButton('compareBtn').attributes();
+    const attrs = findByTestId('compareBtn').attributes();
     expect(attrs['data-track-event']).toBe('click_button');
     expect(attrs['data-track-label']).toBe('compare_all_plans');
     expect(attrs['data-track-property']).toBe('experiment:show_trial_status_in_sidebar');

ee/spec/frontend/contextual_sidebar/group_trial_status_widget_spec.js

@@ -6,7 +6,7 @@ import TrialStatusWidget from 'ee/contextual_sidebar/components/trial_status_wid
 describe('TrialStatusWidget component', () => {
   let wrapper;
 
-  const getGlLink = () => wrapper.findComponent(GlLink);
+  const findGlLink = () => wrapper.findComponent(GlLink);
 
   const createComponent = (props = {}) => {
     return shallowMount(TrialStatusWidget, {
@@ -36,11 +36,11 @@ describe('TrialStatusWidget component', () => {
     });
 
     it('renders without an id', () => {
-      expect(getGlLink().attributes('id')).toBe(undefined);
+      expect(findGlLink().attributes('id')).toBe(undefined);
     });
 
     it('renders with the correct tracking data attributes', () => {
-      const attrs = getGlLink().attributes();
+      const attrs = findGlLink().attributes();
       expect(attrs['data-track-event']).toBe('click_link');
       expect(attrs['data-track-label']).toBe('trial_status_widget');
       expect(attrs['data-track-property']).toBe('experiment:show_trial_status_in_sidebar');
@@ -53,7 +53,7 @@ describe('TrialStatusWidget component', () => {
     });
 
     it('renders with the given id', () => {
-      expect(getGlLink().attributes('id')).toBe('some-id');
+      expect(findGlLink().attributes('id')).toBe('some-id');
     });
   });
 });