Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
a7743dd3
Commit
a7743dd3
authored
Nov 10, 2021
by
Désirée Chevalier
Committed by
Dan Davison
Nov 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add UI wait for labels_widget ff functionality
parent
f257915e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
1 deletion
+13
-1
qa/qa/page/component/issuable/sidebar.rb
qa/qa/page/component/issuable/sidebar.rb
+9
-0
qa/qa/specs/features/ee/browser_ui/2_plan/scoped_labels/editing_scoped_labels_spec.rb
...ser_ui/2_plan/scoped_labels/editing_scoped_labels_spec.rb
+4
-1
No files found.
qa/qa/page/component/issuable/sidebar.rb
View file @
a7743dd3
...
@@ -124,6 +124,15 @@ module QA
...
@@ -124,6 +124,15 @@ module QA
click_element
(
:more_assignees_link
)
click_element
(
:more_assignees_link
)
end
end
# When the labels_widget feature flag is enabled, wait until the labels widget appears
def
wait_for_labels_widget_feature_flag
Support
::
Retrier
.
retry_until
(
max_duration:
60
,
reload_page:
page
,
retry_on_exception:
true
,
sleep_interval:
5
)
do
within_element
(
:labels_block
)
do
find_element
(
:edit_link
)
end
end
end
private
private
def
wait_assignees_block_finish_loading
def
wait_assignees_block_finish_loading
...
...
qa/qa/specs/features/ee/browser_ui/2_plan/scoped_labels/editing_scoped_labels_spec.rb
View file @
a7743dd3
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
module
QA
module
QA
# TODO: Remove :requires_admin when the `Runtime::Feature.enable` method call is removed
# TODO: Remove :requires_admin when the `Runtime::Feature.enable` method call is removed
RSpec
.
describe
'Plan'
,
:requires_admin
,
quarantine:
{
issue:
'https://gitlab.com/gitlab-org/gitlab/-/issues/345076'
,
type: :flaky
}
do
RSpec
.
describe
'Plan'
,
:requires_admin
do
describe
'Editing scoped labels on issues'
do
describe
'Editing scoped labels on issues'
do
let
(
:initial_label
)
{
'animal::fox'
}
let
(
:initial_label
)
{
'animal::fox'
}
let
(
:new_label_same_scope
)
{
'animal::dolphin'
}
let
(
:new_label_same_scope
)
{
'animal::dolphin'
}
...
@@ -43,6 +43,9 @@ module QA
...
@@ -43,6 +43,9 @@ module QA
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1181'
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1181'
)
do
)
do
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show
|
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show
|
# TODO: Remove this method when the `Runtime::Feature.enable` method call is removed
show
.
wait_for_labels_widget_feature_flag
show
.
select_labels
(
show
.
select_labels
(
[
[
new_label_same_scope
,
new_label_same_scope
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment