Merge branch 'jc-fix-relative-link-filter' into 'master'

Do not load uri types if there are no linkable attributes

Closes #33407

See merge request gitlab-org/gitlab!18241

lib/banzai/filter/relative_link_filter.rb

@@ -21,6 +21,7 @@ module Banzai
         return doc if context[:system_note]
 
         clear_memoization(:linkable_files)
+        clear_memoization(:linkable_attributes)
 
         load_uri_types
 
@@ -35,10 +36,9 @@ module Banzai
 
       def load_uri_types
         return unless linkable_files?
+        return unless linkable_attributes.present?
         return {} unless repository
 
-        clear_memoization(:linkable_attributes)
-
         @uri_types = request_path.present? ? get_uri_types([request_path]) : {}
 
         paths = linkable_attributes.flat_map do |attr|

spec/lib/banzai/filter/relative_link_filter_spec.rb

@@ -228,6 +228,12 @@ describe Banzai::Filter::RelativeLinkFilter do
       expect(doc.at_css('a')['href']).to eq 'http://example.com'
     end
 
+    it 'does not call gitaly' do
+      filter(link('http://example.com'))
+
+      expect(described_class).not_to receive(:get_blob_types)
+    end
+
     it 'supports Unicode filenames' do
       path = 'files/images/한글.png'
       escaped = Addressable::URI.escape(path)