Commit a87528dd authored by Simon Knox's avatar Simon Knox

Enable board_new_list and iteration_board_lists feature flags by default

parent 66ce587c
...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/299366 ...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/299366
milestone: '13.8' milestone: '13.8'
type: development type: development
group: group::project management group: group::project management
default_enabled: false default_enabled: true
...@@ -342,14 +342,16 @@ As in other list types, click the trash icon to remove a list. ...@@ -342,14 +342,16 @@ As in other list types, click the trash icon to remove a list.
### Iteration lists **(PREMIUM)** ### Iteration lists **(PREMIUM)**
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/250479) in GitLab 13.10. > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/250479) in GitLab 13.11.
> - It's [deployed behind the `board_new_lists` and `iteration_board_lists` feature flags](../feature_flags.md), disabled by default. > - [Deployed behind the `board_new_lists` and `iteration_board_lists` feature flags](../feature_flags.md), disabled by default.
> - It's disabled on GitLab.com. > - [Enabled by default](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57439) in GitLab 13.11.
> - It's recommended for production use. > - Enabled on GitLab.com.
> - To use it in GitLab self-managed instances, ask a GitLab administrator to enable the feature flags: [`board_new_lists`](#enable-or-disable-new-add-list-form) and [`iteration_board_lists`](#enable-or-disable-iteration-lists-in-boards). > - Recommended for production use.
> - For GitLab self-managed instances, GitLab administrators can opt to disable the feature flags: [`board_new_lists`](#enable-or-disable-new-add-list-form) and [`iteration_board_lists`](#enable-or-disable-iteration-lists-in-boards). **(PREMIUM SELF)**
WARNING: There can be
This feature might not be available to you. Check the **version history** note above for details. [risks when disabling released features](../feature_flags.md#risks-when-disabling-released-features).
Refer to this feature's version history for more details.
You're also able to create lists of an iteration. You're also able to create lists of an iteration.
These are lists that filter issues by the assigned These are lists that filter issues by the assigned
...@@ -646,10 +648,10 @@ Feature.disable(:graphql_board_lists) ...@@ -646,10 +648,10 @@ Feature.disable(:graphql_board_lists)
### Enable or disable new add list form **(FREE SELF)** ### Enable or disable new add list form **(FREE SELF)**
The new form for adding lists is under development and not ready for production use. It is The new form for adding lists is under development but ready for production use. It is
deployed behind a feature flag that is **disabled by default**. deployed behind a feature flag that is **enabled by default**.
[GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md) [GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
can enable it. can disable it.
To enable it: To enable it:
...@@ -666,12 +668,12 @@ Feature.disable(:board_new_list) ...@@ -666,12 +668,12 @@ Feature.disable(:board_new_list)
### Enable or disable iteration lists in boards **(PREMIUM SELF)** ### Enable or disable iteration lists in boards **(PREMIUM SELF)**
NOTE: NOTE:
To enable iteration lists in boards, you also need to enable the [new add list form](#enable-or-disable-new-add-list-form). When disabling iteration lists in boards, you also need to disable the [new add list form](#enable-or-disable-new-add-list-form).
The iteration list is under development and not ready for production use. It is The iteration list is under development but ready for production use. It is
deployed behind a feature flag that is **disabled by default**. deployed behind a feature flag that is **enabled by default**.
[GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md) [GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
can enable it. can disable it.
To enable it: To enable it:
......
...@@ -65,7 +65,7 @@ module EE ...@@ -65,7 +65,7 @@ module EE
def all_iteration_lists def all_iteration_lists
# Note that the names are very similar but these are different. # Note that the names are very similar but these are different.
# One is a license name and the other is a feature flag # One is a license name and the other is a feature flag
if parent.feature_available?(:board_iteration_lists) && ::Feature.enabled?(:iteration_board_lists, parent) if parent.feature_available?(:board_iteration_lists) && ::Feature.enabled?(:iteration_board_lists, parent, default_enabled: :yaml)
board.lists.iteration.where.not(iteration_id: nil) board.lists.iteration.where.not(iteration_id: nil)
else else
::List.none ::List.none
......
...@@ -39,7 +39,7 @@ module EE ...@@ -39,7 +39,7 @@ module EE
milestone_id: milestone_id milestone_id: milestone_id
} }
movement_args[:sprint_id] = iteration_id(issue) if ::Feature.enabled?(:iteration_board_lists, parent) movement_args[:sprint_id] = iteration_id(issue) if ::Feature.enabled?(:iteration_board_lists, parent, default_enabled: :yaml)
movement_args movement_args
end end
......
...@@ -10,7 +10,7 @@ module EE ...@@ -10,7 +10,7 @@ module EE
override :execute override :execute
def execute(board) def execute(board)
return ServiceResponse.error(message: 'iteration_board_lists feature flag is disabled') if type == :iteration && ::Feature.disabled?(:iteration_board_lists, board.resource_parent) return ServiceResponse.error(message: 'iteration_board_lists feature flag is disabled') if type == :iteration && ::Feature.disabled?(:iteration_board_lists, board.resource_parent, default_enabled: :yaml)
return license_validation_error unless valid_license?(board.resource_parent) return license_validation_error unless valid_license?(board.resource_parent)
super super
......
...@@ -18,7 +18,7 @@ module EE ...@@ -18,7 +18,7 @@ module EE
def unavailable_list_types_for(board) def unavailable_list_types_for(board)
list_types = super list_types = super
list_types += unlicensed_lists_for(board) list_types += unlicensed_lists_for(board)
list_types << ::List.list_types[:iteration] if ::Feature.disabled?(:iteration_board_lists, board.resource_parent) list_types << ::List.list_types[:iteration] if ::Feature.disabled?(:iteration_board_lists, board.resource_parent, default_enabled: :yaml)
list_types.uniq list_types.uniq
end end
......
---
title: Enable iteration lists and new create list form
merge_request: 57439
author:
type: changed
...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/250479 ...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/250479
milestone: '13.7' milestone: '13.7'
type: development type: development
group: group::project management group: group::project management
default_enabled: false default_enabled: true
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment