Fixed Rubocop dependent offenses

These are specific to EE and a whole bunch of these can be fixed by just
removing the `dependent:` option since we now have more foreign keys in
place.

app/models/ee/namespace.rb

@@ -19,7 +19,7 @@ module EE
     }.freeze
 
     prepended do
-      has_one :namespace_statistics, dependent: :destroy
+      has_one :namespace_statistics
 
       scope :with_plan, -> { where.not(plan: [nil, '']) }
 

app/models/ee/project.rb

@@ -24,17 +24,17 @@ module EE
 
       belongs_to :mirror_user, foreign_key: 'mirror_user_id', class_name: 'User'
 
-      has_one :mirror_data, dependent: :delete, autosave: true, class_name: 'ProjectMirrorData'
-      has_one :push_rule, ->(project) { project&.feature_available?(:push_rules) ? all : none }, dependent: :destroy
-      has_one :index_status, dependent: :destroy
-      has_one :jenkins_service, dependent: :destroy
-      has_one :jenkins_deprecated_service, dependent: :destroy
-
-      has_many :approvers, as: :target, dependent: :destroy
-      has_many :approver_groups, as: :target, dependent: :destroy
-      has_many :audit_events, as: :entity, dependent: :destroy
-      has_many :remote_mirrors, inverse_of: :project, dependent: :destroy
-      has_many :path_locks, dependent: :destroy
+      has_one :mirror_data, autosave: true, class_name: 'ProjectMirrorData'
+      has_one :push_rule, ->(project) { project&.feature_available?(:push_rules) ? all : none }
+      has_one :index_status
+      has_one :jenkins_service
+      has_one :jenkins_deprecated_service
+
+      has_many :approvers, as: :target, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
+      has_many :approver_groups, as: :target, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
+      has_many :audit_events, as: :entity, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
+      has_many :remote_mirrors, inverse_of: :project
+      has_many :path_locks
 
       scope :with_shared_runners_limit_enabled, -> { with_shared_runners.non_public_only }
 

app/models/geo_node.rb

 class GeoNode < ActiveRecord::Base
   include Presentable
 
-  belongs_to :geo_node_key, dependent: :destroy
-  belongs_to :oauth_application, class_name: 'Doorkeeper::Application', dependent: :destroy
-  belongs_to :system_hook, dependent: :destroy
+  belongs_to :geo_node_key, dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
+  belongs_to :oauth_application, class_name: 'Doorkeeper::Application', dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
+  belongs_to :system_hook, dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
 
   default_values schema: lambda { Gitlab.config.gitlab.protocol },
                  host: lambda { Gitlab.config.gitlab.host },

app/models/group.rb

@@ -27,12 +27,12 @@ class Group < Namespace
   has_many :notification_settings, dependent: :destroy, as: :source # rubocop:disable Cop/ActiveRecordDependent
   has_many :labels, class_name: 'GroupLabel'
 
-  has_many :ldap_group_links, foreign_key: 'group_id', dependent: :destroy
-  has_many :hooks, dependent: :destroy, class_name: 'GroupHook'
+  has_many :ldap_group_links, foreign_key: 'group_id', dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
+  has_many :hooks, dependent: :destroy, class_name: 'GroupHook' # rubocop:disable Cop/ActiveRecordDependent
 
   # We cannot simply set `has_many :audit_events, as: :entity, dependent: :destroy`
   # here since Group inherits from Namespace, the entity_type would be set to `Namespace`.
-  has_many :audit_events, -> { where(entity_type: Group) }, dependent: :destroy, foreign_key: 'entity_id'
+  has_many :audit_events, -> { where(entity_type: Group) }, dependent: :delete_all, foreign_key: 'entity_id' # rubocop:disable Cop/ActiveRecordDependent
 
   validate :avatar_type, if: ->(user) { user.avatar.present? && user.avatar_changed? }
   validate :visibility_level_allowed_by_projects

app/models/merge_request.rb

@@ -15,7 +15,7 @@ class MergeRequest < ActiveRecord::Base
   belongs_to :source_project, class_name: "Project"
   belongs_to :merge_user, class_name: "User"
 
-  has_many :approvals
+  has_many :approvals, dependent: :delete_all # rubocop:disable Cop/ActiveRecordDependent
   has_many :approvers, as: :target, dependent: :delete_all # rubocop:disable Cop/ActiveRecordDependent
   has_many :approver_groups, as: :target, dependent: :delete_all # rubocop:disable Cop/ActiveRecordDependent
   has_many :merge_request_diffs

app/models/user.rb

@@ -119,14 +119,14 @@ class User < ActiveRecord::Base
   has_many :todos,                    dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
   has_many :notification_settings,    dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
   has_many :award_emoji,              dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
-  has_many :path_locks,               dependent: :destroy
+  has_many :path_locks,               dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
 
-  has_many :approvals,                dependent: :destroy
-  has_many :approvers,                dependent: :destroy
+  has_many :approvals,                dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
+  has_many :approvers,                dependent: :destroy # rubocop: disable Cop/ActiveRecordDependent
 
   # Protected Branch Access
-  has_many :protected_branch_merge_access_levels, dependent: :destroy, class_name: ProtectedBranch::MergeAccessLevel
-  has_many :protected_branch_push_access_levels, dependent: :destroy, class_name: ProtectedBranch::PushAccessLevel
+  has_many :protected_branch_merge_access_levels, dependent: :destroy, class_name: ProtectedBranch::MergeAccessLevel # rubocop:disable Cop/ActiveRecordDependent
+  has_many :protected_branch_push_access_levels, dependent: :destroy, class_name: ProtectedBranch::PushAccessLevel # rubocop:disable Cop/ActiveRecordDependent
   has_many :triggers,                 dependent: :destroy, class_name: 'Ci::Trigger', foreign_key: :owner_id # rubocop:disable Cop/ActiveRecordDependent
 
   has_many :issue_assignees

spec/models/ee/namespace_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe Namespace, models: true do
   let!(:namespace) { create(:namespace) }
 
-  it { is_expected.to have_one(:namespace_statistics).dependent(:destroy) }
+  it { is_expected.to have_one(:namespace_statistics) }
 
   it { is_expected.to delegate_method(:shared_runners_minutes).to(:namespace_statistics) }
   it { is_expected.to delegate_method(:shared_runners_seconds).to(:namespace_statistics) }

spec/models/project_spec.rb

@@ -51,7 +51,7 @@ describe Project, models: true do
     it { is_expected.to have_one(:project_feature) }
     it { is_expected.to have_one(:statistics).class_name('ProjectStatistics') }
     it { is_expected.to have_one(:import_data).class_name('ProjectImportData') }
-    it { is_expected.to have_one(:mirror_data).class_name('ProjectMirrorData').dependent(:delete) }
+    it { is_expected.to have_one(:mirror_data).class_name('ProjectMirrorData') }
     it { is_expected.to have_one(:last_event).class_name('Event') }
     it { is_expected.to have_one(:forked_from_project).through(:forked_project_link) }
     it { is_expected.to have_many(:commit_statuses) }
@@ -63,7 +63,7 @@ describe Project, models: true do
     it { is_expected.to have_many(:variables) }
     it { is_expected.to have_many(:triggers) }
     it { is_expected.to have_many(:pages_domains) }
-    it { is_expected.to have_many(:path_locks).dependent(:destroy) }
+    it { is_expected.to have_many(:path_locks) }
     it { is_expected.to have_many(:labels).class_name('ProjectLabel') }
     it { is_expected.to have_many(:users_star_projects) }
     it { is_expected.to have_many(:environments) }