Commit a901c405 authored by Sarah Yasonik's avatar Sarah Yasonik Committed by Mayra Cabrera

Enable feature flag by default

Incidents created from alerts are automatically escalated to on-call
users via the alert. This change allows
users to escalate incidents which have been created manually by setting
an escalation policy for the incident. The status of the incident can be
used to acknowledge the pages from the escalation.

Changelog: added
parent 12ba23ee
...@@ -7,7 +7,7 @@ class Projects::IncidentsController < Projects::ApplicationController ...@@ -7,7 +7,7 @@ class Projects::IncidentsController < Projects::ApplicationController
before_action :authorize_read_issue! before_action :authorize_read_issue!
before_action :load_incident, only: [:show] before_action :load_incident, only: [:show]
before_action do before_action do
push_frontend_feature_flag(:incident_escalations, @project) push_frontend_feature_flag(:incident_escalations, @project, default_enabled: :yaml)
push_frontend_feature_flag(:incident_timeline, @project, default_enabled: :yaml) push_frontend_feature_flag(:incident_timeline, @project, default_enabled: :yaml)
end end
......
...@@ -38,7 +38,7 @@ module Mutations ...@@ -38,7 +38,7 @@ module Mutations
def disabled_sort_value?(args) def disabled_sort_value?(args)
return false unless [:escalation_status_asc, :escalation_status_desc].include?(args[:issues_sort]) return false unless [:escalation_status_asc, :escalation_status_desc].include?(args[:issues_sort])
Feature.disabled?(:incident_escalations) Feature.disabled?(:incident_escalations, default_enabled: :yaml)
end end
end end
end end
......
...@@ -35,7 +35,7 @@ module Resolvers ...@@ -35,7 +35,7 @@ module Resolvers
def prepare_params(args, parent) def prepare_params(args, parent)
return unless [:escalation_status_asc, :escalation_status_desc].include?(args[:sort]) return unless [:escalation_status_asc, :escalation_status_desc].include?(args[:sort])
return if Feature.enabled?(:incident_escalations, parent) return if Feature.enabled?(:incident_escalations, parent, default_enabled: :yaml)
args[:sort] = :created_desc # default for sort argument args[:sort] = :created_desc # default for sort argument
end end
......
...@@ -195,7 +195,7 @@ module Issuable ...@@ -195,7 +195,7 @@ module Issuable
end end
def supports_escalation? def supports_escalation?
return false unless ::Feature.enabled?(:incident_escalations, project) return false unless ::Feature.enabled?(:incident_escalations, project, default_enabled: :yaml)
incident? incident?
end end
......
...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/345769 ...@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/345769
milestone: '14.6' milestone: '14.6'
type: development type: development
group: group::respond group: group::respond
default_enabled: false default_enabled: true
...@@ -255,11 +255,12 @@ Add a to-do for incidents that you want to track in your to-do list. Click the ...@@ -255,11 +255,12 @@ Add a to-do for incidents that you want to track in your to-do list. Click the
### Change incident status ### Change incident status
> [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default. > - [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default.
> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/345769) in GitLab 14.10.
FLAG: FLAG:
By default this feature is not available. To make it available per project or for your entire This feature is available by default. To disable it per project or for your entire
instance, ask an administrator to [enable the feature flag](../../administration/feature_flags.md) instance, ask an administrator to [disable the feature flag](../../administration/feature_flags.md)
named `incident_escalations`. named `incident_escalations`.
For users with the Developer role or higher, select **Edit** in the **Status** section of the For users with the Developer role or higher, select **Edit** in the **Status** section of the
...@@ -278,11 +279,12 @@ updating the incident status also updates the alert status. ...@@ -278,11 +279,12 @@ updating the incident status also updates the alert status.
### Change escalation policy **(PREMIUM)** ### Change escalation policy **(PREMIUM)**
> [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default. > - [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default.
> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/345769) in GitLab 14.10.
FLAG: FLAG:
By default this feature is not available. To make it available per project or for your entire This feature is available by default. To disable it per project or for your entire
instance, ask an administrator to [enable the feature flag](../../administration/feature_flags.md) instance, ask an administrator to [disable the feature flag](../../administration/feature_flags.md)
named `incident_escalations`. named `incident_escalations`.
For users with the Developer role or higher, select **Edit** in the **Escalation policy** section of For users with the Developer role or higher, select **Edit** in the **Escalation policy** section of
......
...@@ -50,11 +50,12 @@ or stop alert escalations by [updating the alert's status](alerts.md#update-an-a ...@@ -50,11 +50,12 @@ or stop alert escalations by [updating the alert's status](alerts.md#update-an-a
### Escalating an incident ### Escalating an incident
> [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default. > - [Introduced](https://gitlab.com/groups/gitlab-org/-/epics/5716) in GitLab 14.9 [with a flag](../../administration/feature_flags.md) named `incident_escalations`. Disabled by default.
> - [Enabled on GitLab.com and self-managed](https://gitlab.com/gitlab-org/gitlab/-/issues/345769) in GitLab 14.10.
FLAG: FLAG:
By default this feature is not available. To make it available per project or for your entire This feature is available by default. To disable it per project or for your entire
instance, ask an administrator to [enable the feature flag](../../administration/feature_flags.md) instance, ask an administrator to [disable the feature flag](../../administration/feature_flags.md)
named `incident_escalations`. named `incident_escalations`.
For incidents, paging on-call responders is optional for each individual incident. For incidents, paging on-call responders is optional for each individual incident.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment